Comments (4)
Can you give steps to repro? I think this only happens immediately after an incident is created, before the first notification is sent out (e.g. testing a plan, then immediately looking at the incident page). Here, "step 0" is a little confusing, but technically correct, since Iris hasn't started executing step 1 yet.
from iris.
- Use 'Test Plan' with any plan
- Switch to Incidents tab
- Note that in the list view, your incident notes "Current Step: 0"
- Wait until iris-sender comes by, note that in the list view "Current Step: 1"
In the individual incident view, "$planname: step $n" is used.
I think the confusion is with the language usage. The current wording implies "you are at step X". Which in my understanding means "you are anywhere between the start and the end of step X".
Really, what the current step value means, and the language should reflect: "Completed step X". By using such wording it would be silly to say "Completed step 0". Instead something like "To be processed" would be more appropriate.
If we can agree on that the current language usage suggests we are at step X rather than we've completed step X, I'd suggest keeping the wording and changing the step value displayed (current/"at" vs completed step number).
Thoughts?
from iris.
I'm a little confused by this. When I create a plan with multiple steps (specifically, one notification per step with wait == 1 and count == 2), things seem to behave as one would expect (i.e. "You are at step 1"). For example, after receiving the first message in step 1 but before receiving the second one, going to the incident page resulted in a "Current step: 1". Is the plan you're testing with a little more complicated?
Another nuance with plan steps is that the plan will proceed to step 2 after the first notification in step 1 completes. For example, if I have notification A in step 1 with count == 5, wait == 5 and notification B with count == 1, wait == 5, the plan will proceed to step 2 5 minutes after notification B is sent. Could this account for what you're seeing?
from iris.
For example, after receiving the first message in step 1 but before receiving the second one,
going to the incident page resulted in a "Current step: 1".
Is the plan you're testing with a little more complicated?
No, this is exactly what I'm seeing with a plan similar to what you describe.
What you're saying is completely correct. My point is that it's not intuitive - because there's no such thing as a "step 0"
It's like giving someone instructions and later you ask how far along they are. Currently Iris responds:
"I'm at step 0"
Where as a more logical response would be:
"Oh sorry John, I haven't started yet" ;)
Anyway, in the end this is just a nitpick. If I fail to convince anyone then that's fine too :)
from iris.
Related Issues (20)
- Add global setting to not filter default Incident list by owner
- Getting 404 while try to post an incident HOT 4
- Invalid incident
- IRIS ldap not working HOT 3
- > Hello! How to connect AVAX to METAMASK? HOT 2
- I wish I knew what you guys are talking about
- Error while sending message or call to target HOT 4
- Hello! How to connect AVAX to METAMASK? HOT 2
- no python application found -- error HOT 1
- Unable to publish new (or existing) Plan HOT 2
- Additional Functionality: To introduce a DAO layer to leverage Iris functionality with different Databases.
- Create Plan Fail HOT 2
- Configuration as code HOT 1
- Feature request: Extract fields from AlertManager labels into top level context HOT 1
- Status of Container Images HOT 1
- Error during make on Quickstart setup
- IRIS ldap not working HOT 6
- Applications are not properly loaded when using uwsgi
- Able to trigger call from iris with out API Key is this an expected one HOT 2
- Getting error while running GET_INACTIVE_IDS_SQL sql query HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iris.