Some dependencies in /core module are in the wrong scope. about armeria HOT 5 CLOSED

Good question.

com.google.common.collect.ImmutableList.Builder in guava is used as public method parameter in

Though they have public visibility, classes under internal packages are internal classes.

In addition to Bouncycastle, we also shadow Guava dependency. If it is exposed in the public API, we should fix it instead of making it api.

from armeria.

Could you help me review this issue @ikhoon @minwoox ? Many thanks :)

from armeria.

Class io.netty.channel.unix.DomainSocketAddress is used as public method parameter in core/src/main/java/com/linecorp/armeria/common/util/DomainSocketAddress.java

Good point. We need to fix it.

Class AsymmetricKeyInfoConverter is used as public method parameter in core/src/main/java/com/linecorp/armeria/internal/common/util/MinifiedBouncyCastleProvider.java

bouncycastle is shaded so it is not part of transitive dependencies and can't be api.
We may remove ConfigurableProvider from the super class or move MinifiedBouncyCastleProvider to internal.

Class ForwardingSet is extended in core/src/main/java/com/linecorp/armeria/common/DefaultCookies.java

DefaultCookies is a package private class so ForwardingSet doesn't have to be api.

from armeria.

@ikhoon Thanks a lot for your prompt response and clarification!

DefaultCookies is a package private class so ForwardingSet doesn't have to be api.

You're right, I'm sorry to give a wrong example. But here's another example regarding exposed classses in guava. Could you please take a look?

• com.google.common.collect.ImmutableList.Builder in guava is used as public method parameter in core/src/main/java/com/linecorp/armeria/internal/common/metric/DefaultMeterIdPrefixFunction.java

Acually we found another dependency com.github.ben-manes.caffeine:caffeine whose scope may also need to be set to api due to the following usage.

• com.github.benmanes.caffeine.cache.Cache in caffeine is used as public parameter in core/src/main/java/com/linecorp/armeria/internal/common/metric/CaffeineMetricSupport.java

from armeria.

@ikhoon Thank you for your response :). I now have a thorough understanding of the situation, and the problem should be fixed according to armeria's actual implementation. Hope to hear it fixed soon :).

from armeria.