Code Monkey home page Code Monkey logo

Comments (2)

ikhoon avatar ikhoon commented on June 12, 2024 1

I wrote this issue because it would be good for users to freely control connection preface or Upgrade: h2c using the flag for debugging purposes. That said, I have doubts about whether the feature is really necessary. It may bring unnecessary complexity.

We need to hear the opinions of other maintainers and users, but we may treat the existing behavior, which defaultUseHttp2Preface affects h2c, as a bug.

I think applying the defaultUseHttp2Preface flag only to http is straightforward and makes sense.

from armeria.

ks-yim avatar ks-yim commented on June 12, 2024

Hi, I'd like to work on a PR for this, but I'd like to confirm the following point before I start working on this.
Would there be a real or at least a debugging use case of using Upgrade: h2c header over HTTP/1.1 to the endpoints explicitly configured to use h2c?

Asking this because...:

  1. If the endpoint doesn't support Upgrade: h2c over HTTP/1.1, Armeria client will throw SessionProtocolNegotiationException.
  2. A server that supports Upgrade: h2c upgrade will almost always support HTTP/2 prior knowledge.

from armeria.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.