Code Monkey home page Code Monkey logo

Comments (5)

dominik-kopczynski avatar dominik-kopczynski commented on July 26, 2024

Hi Semer,

I am sorry that I overlooked your issue, my apologies. Can you please tell me which rgoslin version you are using? The current version in the master branch is 1.3.2. This version should cope without problems, when you have lipid names only on species level, e.g., Cer 40:1;O2.

  1. Yes, the conversion from CE to SE 27:1 is due to the fact that in the current shorthand nomenclature [1], the lipids are annotated like this. I am also not a big fan of this change, but we want to keep the tool coherent with the latest nomenclature. Maybe they change it again in the future.

  2. I would like you to test again the lipid name conversion with the current version:

library(rgoslin)
lipid_names = c("PA 12:0/14:0", "PC(18:0/14:0)", "SM(d16:1/12:2)", "TG 16:0_18:2_22:5", "Cer 42:2;O2")
parsed <- parseLipidNames(lipid_names)
parsed["Normalized.Name"]
#>    Normalized.Name
#> 1      PA 12:0/14:0
#> 2      PC 18:0/14:0
#> 3   SM 16:1;O2/12:2
#> 4 TG 16:0_18:2_22:5
#> 5       Cer 42:2;O2

If you still have problems, please feel free to drop us a line, we would appreciate that.

Cheers,
Dominik
[1] https://www.babraham.ac.uk/sites/default/files/2021-03/33037133.pdf

from rgoslin.

semer94 avatar semer94 commented on July 26, 2024

Thank you for your response!

I am using rgoslin v 1.4.0. The code you provided works fine, but I am having trouble making the lipid names properly read by lipidr after trying the following code

`lpd <- as_lipidomics_experiment(lip)

parsed <- parseLipidNames(rowData(lpd)$Molecule)

lpd <- update_molecule_names(lpd, rowData(lpd)$Molecule, parsed$Normalized.Name)`

from rgoslin.

dominik-kopczynski avatar dominik-kopczynski commented on July 26, 2024

Hi,

as far as I see, the function update_molecule_names [1] is provided by lipidr and doesn't have any return value according to this manual [1]. It changes the experiment object in-situ without creating a copy. Can you please try this code:

lpd <- as_lipidomics_experiment(lip)
parsed <- parseLipidNames(rowData(lpd)$Molecule)
update_molecule_names(lpd, rowData(lpd)$Molecule, parsed$Normalized.Name)  # without re-assigning lpd

[1] https://rdrr.io/bioc/lipidr/man/update_molecule_names.html

from rgoslin.

semer94 avatar semer94 commented on July 26, 2024

It still reads them as NAs. It is most impressive that using the code I provided in the opening thread the lipids are normally parsed (even though some of them are "cropped") and I am trying to figure out what is actually making the difference.

Thanks again Dominik!

from rgoslin.

dominik-kopczynski avatar dominik-kopczynski commented on July 26, 2024

If you want, we can have a Zoom/Skype/[other funky video tool] meeting to tackle your problem together. It is a little tough for me to give advises when I cannot reproduce the error.

from rgoslin.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.