Code Monkey home page Code Monkey logo

Comments (7)

negativeExponent avatar negativeExponent commented on May 28, 2024 1

the core is base on pce_fast, which with its libretro modifications can be called pce_fast_fast (yeah). So removing issue only for PCE and SuperGrafx, these are the relevant changes:

PCE, PSX, PCE_FAST: Avoid UB by biasing uintptr_t values instead of pointers directly in the CPU core.
PCE, PCE_FAST: Added a missing sound emulation variable to save states.
PCE_FAST: Fixed fubared mouse emulation.

doesn't look like game-breaking atm though without them. will probably look into it sometime unless someone does it first (does anyone care here about states compatibility, coz that will break with the changes)

from beetle-pce-fast-libretro.

negativeExponent avatar negativeExponent commented on May 28, 2024 1

looking at past PR's, it seems that i have already addressed these before

  • Avoid UB by biasing uintptr_t values instead of pointers directly in the CPU core - 83a234a
  • Fixed fubared mouse emulation. - 5a1cfa4

I skipped save states coz it will break compatibility. So, its just a matter of bumping the version number which i havent done coz there is really nothing much related changes to the core since 9.39.2

from beetle-pce-fast-libretro.

mrjschulte avatar mrjschulte commented on May 28, 2024

Had a quick look at doing this and the amount of work needed is not insignificant.

from beetle-pce-fast-libretro.

hizzlekizzle avatar hizzlekizzle commented on May 28, 2024

That's a shame, but thanks for looking into it :)

from beetle-pce-fast-libretro.

ToniBC avatar ToniBC commented on May 28, 2024

Not everything has to be done at one time, little by little it can be improved to update it, it is what happens when the projects "leave" for a long time.

I left this to remember that a revision is needed so that this core is at the same level as the base and that the emulation is better.

But anyway, thanks for looking a little.

from beetle-pce-fast-libretro.

ToniBC avatar ToniBC commented on May 28, 2024

This I published 1 year ago, when the other core was not there or the two branches were together, the PCE and PCE Fast. That is why the changes are included in the two cores.

from beetle-pce-fast-libretro.

negativeExponent avatar negativeExponent commented on May 28, 2024

needless to say, since the missing save states are not harming anything atm. its probably safe for this to close until some major updates are pushed upstream.

from beetle-pce-fast-libretro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.