Building le-master fails about libreelec.tv HOT 24 CLOSED

@Karl-opec did you a complete clean build after the gcc10 merge ?
I needed to do a cd .../LE/ and rm -rf build.* that it works again.

from libreelec.tv.

from libreelec.tv.

I build the chewitt branch amlogic-upstream, which acording to #4467 is a follow up of 4461 and should fix the error. It does not it gives the same error.

`configure: error: libcurses or libncurses are required!
configure: error: /home/rudolf/src/le-amup-20200704/build.LibreELEC-AMLG12.arm-9.80-devel/build/heimdal-7.7.0/lib/libedit/configure failed for lib/libedit
FAILURE: scripts/build heimdal:host during configure_host (default)
*********** FAILED COMMAND ***********
${PKG_CONFIGURE_SCRIPT} ${HOST_CONFIGURE_OPTS} ${PKG_CONFIGURE_OPTS_HOST}

FAILURE: scripts/build heimdal:host has failed!

The following log for this failure is available:
/home/rudolf/src/le-amup-20200704/build.LibreELEC-AMLG12.arm-9.80-devel/.threads/logs/73.log

heimdal:host seq 73 >>>
[079/266] [FAIL] build heimdal:host

The following log for this failure is available:
/home/rudolf/src/le-amup-20200704/build.LibreELEC-AMLG12.arm-9.80-devel/.threads/logs/73.log

Parallel build failure - see log for details. Time of failure: Sat Jul 4 11:17:24 CEST 2020
make: *** [Makefile:12: image] Fehler 1
`

from libreelec.tv.

I've done a clean build of my amlogic-upstream branch without issues on an Ubuntu 18.04 host. After the gcc10 bump it needs to be a clean build - dirty builds will fail.

from libreelec.tv.

I build clean on Opensuse Tumbleweed. I tried your amlogic-upstream branch to have the above mentioned gcc10 fix in place.
I know that this not an preferred build system but in the past it has worked. For me it seems to be an issue with automake, autoconf in the heimdal building process. configure for heimdal says not to build libedit but it tries to do it and then it fails.

from libreelec.tv.

I know that this not an preferred build system but in the past it has worked.

We provide Docker templates in tools/docker for people with unsupported build environments to use.

from libreelec.tv.

Master is also failing for me on Fedora 32 x64 host for building generic image with the same error during heimdal build
ps: with complete clean build of course.

from libreelec.tv.

after some research i am pretty sure, this pr is fixing the issue above: https://github.com/heimdal/heimdal/pull/714/files
edit: no it is not because it is changing only a message, but at least the line above is giving me in hint. at the end tgetent is not found on fedora 32 anymore
edit2: actually the main reason is that tgetent is not buildin ncurses anymore. That heimdal is failing is not new and was fixed earlier here: https://github.com/LibreELEC/LibreELEC.tv/pull/2970/files. This was okay in the past, but with this commit: 07fa29f ncurses is build with termcap/termlib which is putting the necessary functions into tinfo lib. Heimdal is not searching for that the current version. the mentioned PR in heimdal was the last step to change it but the fix is coming into the next version which is currently not released. I wondering why nearly nobody else is failing into that trap since april. A clean build should fail always...

from libreelec.tv.

I've got the same issue :/

from libreelec.tv.

I've got the same issue :/

impossible to know without some kind of log

from libreelec.tv.

You find a log in the first message here :[73.log]https://github.com/LibreELEC/LibreELEC.tv/files/4840318/73.log

from libreelec.tv.

Closing after #4949 bumps everything to a current state again

from libreelec.tv.

with the newest tree I still have the same error.

checking for tgetent in -lcurses... no
checking for tgetent in -lncurses... no
configure: error: libcurses or libncurses are required!
configure: error: /home/rudolf/src/le-che-20210117/build.LibreELEC-AMLGX.arm-9.80-devel/build/heimdal-7.7.0/lib/libedit/configure failed for lib/libedit
FAILURE: scripts/build heimdal:host during configure_host (default)
*********** FAILED COMMAND ***********
${PKG_CONFIGURE_SCRIPT} ${HOST_CONFIGURE_OPTS} ${PKG_CONFIGURE_OPTS_HOST}
**************************************
FAILURE: scripts/build heimdal:host has failed!

Please reopen

from libreelec.tv.

@Karl-opec did you tried if it happens at other LE platforms too (RPi ...)? Its very likely a problem from host side.

You could try to run it at docker too, there it should work regardless of host system.

from libreelec.tv.

Please have a look to my comment above. It is still valid.

from libreelec.tv.

@the-dreamer whats you host system ?

from libreelec.tv.

Fedora, but as the host side is build by build system and is using the lib it should happend on any host

from libreelec.tv.

I normaly run opensuse thumbleweed. On This host system it does not build, on ubuntu in a virtualbox maschine it does. But the-dreamer's comments is a valid statement. I also question myself, why is this heimdal thing not generally fixable? Perhaps their might something problamatic hidden?

from libreelec.tv.

See edit2 from august. Ncurses has changed and heimdal is failing because of it. Next heimdal release will fix it actually in git it is already fixed.

from libreelec.tv.

So the Headline should be corrected to "Building le-master fails - Needs lastest heimdal git to fix"

from libreelec.tv.

@the-dreamer what is the fixing commit in current git? .. i.e. which patch can we backport until heimdal pushes next release.

from libreelec.tv.

the fix is happend on more commits, i hope that is sufficient for successful build:

1. heimdal/heimdal@872222d
2. heimdal/heimdal@180fc33

this is, what is working on my private repo:

new file mode 100644
index 0000000000..4050f21f50
@@ -0,0 +1,20 @@
+--- a/lib/libedit/configure.ac	2020-08-20 09:39:16.032995156 +0200
++++ b/lib/libedit/configure.ac	2020-08-20 09:28:09.474773594 +0200
+@@ -18,6 +18,7 @@
+ AC_USE_SYSTEM_EXTENSIONS
+ 
+ AM_INIT_AUTOMAKE
++AM_MAINTAINER_MODE
+ AC_PROG_LIBTOOL
+ 
+ # libtool -version-info
+@@ -35,7 +36,8 @@
+ 
+ AC_CHECK_LIB(curses, tgetent,,
+    [AC_CHECK_LIB(ncurses, tgetent,,
+-      [AC_MSG_ERROR([libcurses or libncurses are required!])] )] )
++      [AC_CHECK_LIB(tinfo, tgetent,,
++         [AC_MSG_ERROR([libcurses, libncurses, or tinfo are required!])] )] )] )
+ 
+ 
+ # Checks for header files.

from libreelec.tv.

I have modified the above Patch to be useable in the Build System:

--- heimdal-7.7.0/lib/libedit/configure.ac.orig	2019-06-06 04:56:55.000000000 +0200
+++ heimdal-7.7.0/lib/libedit/configure.ac	2021-01-19 11:14:16.305614445 +0100
@@ -18,6 +18,7 @@ AC_CONFIG_HEADER([config.h])
 AC_USE_SYSTEM_EXTENSIONS
 
 AM_INIT_AUTOMAKE
+AM_MAINTAINER_MODE
 AC_PROG_LIBTOOL
 
 # libtool -version-info
@@ -35,8 +36,8 @@ EL_MANTYPE
 
 AC_CHECK_LIB(curses, tgetent,,
    [AC_CHECK_LIB(ncurses, tgetent,,
-      [AC_MSG_ERROR([libcurses or libncurses are required!])] )] )
-
+      [AC_CHECK_LIB(tinfo, tgetent,,
+         [AC_MSG_ERROR([libcurses, libncurses, or tinfo are required!])] )] )] )
 
 # Checks for header files.
 AC_HEADER_DIRENT

I placed it as packages/devel/heimdal/patches/0001-heimdal-compile.patch in the build system
and building on opensuse tumbleweed works again.

For me this issue is solved now.

Thanks everybody.

from libreelec.tv.

@chewitt or CvH
Could you be so kind to add the above Patch to the source. It really fixes the build issues under other systems. The compiled
code runs without issues.

from libreelec.tv.