Add spock unit test integration about ashley HOT 8 CLOSED

That's a bold statement. JUnit is already easily integrated with gradle, gradle test

from ashley.

What I meant was that spock has its own JUnit runner so it is compatible with most build tools and IDEs same as JUnit (gradle test) with the benefits of simplicity and expressiveness.

from ashley.

I've taken a look at spock and, while it's more expressive than regular Java, it doesn't add much to what we already have with JUnit.

The advantage of using JUnit is that it's plain old Java, just like Ashley. So everyone who contributes to Ashley has a very low entry barrier to write a test. On the other hand, if we used spock, they'd have to spend some time and they might just not write the test.

Although spock is simple, I think the extra dependency is not well justified enough. Nevertheless, I would love to receive some PRs with JUnit tests for Ashley.

I appreciate you taking the time to look into alternatives as well, thanks!

from ashley.

I would be, however, interested in running performance tests with something like JUnitBenchmarks or JUnitPerf.

from ashley.

Integrating Spock doesn't mean you need to do every test with spock, you can have both (both running from gradle test) and even the tests report is unified.

i.e:

:core:test

ashley.ComponentTypeTests > sameComponentType FAILED
    java.lang.AssertionError: Values should be different. Actual: 2
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failEquals(Assert.java:185)
        at org.junit.Assert.assertNotEquals(Assert.java:161)
        at org.junit.Assert.assertNotEquals(Assert.java:198)
        at org.junit.Assert.assertNotEquals(Assert.java:209)
        at ashley.ComponentTypeTests.sameComponentType(ComponentTypeTests.java:27)

ashley.ComponentTypeSpec > Should have the same component type FAILED
    Condition not satisfied:

    componentType1.getIndex() != componentType2.getIndex()
    |              |          |  |              |
    |              5          |  |              5
    |                         |  ashley.core.ComponentType@51666b48
    |                         false
    ashley.core.ComponentType@51666b48
        at ashley.ComponentTypeSpec.Should have the same component type(ComponentTypeSpec.groovy:17)

18 tests completed, 2 failed
:core:test FAILED

About benchmarking, it would be really cool if we have some performance tests and maybe some comparisons with Artemis.

from ashley.

Wow, that looks quite comprehensive! Thanks @andresaraujo, it could be a good addition. Let me think about it, is that okay?

What do you think @stbachmann?

from ashley.

Reminds me of the output that clang generates.

from ashley.

@siondream sure no problem :)

from ashley.