lianxmfor / feastore Goto Github PK

Check list

we should modify the function definition of the get_entity method for more flexibility.
current:
async fn get_entity(&self, name: &str) -> Result<Option<Entity>>
after:
async fn get_entity(&self, opt: metadata::types::GetEntityOpt) -> Result<Option<Entity>>

GetEntityOpt:

pub enum GetEntityOpt<'a> {
    id(i64),
    name( &'a str),
}

I think the list_entity definition should be: async fn list_entity(&self, ids: metadata::ListEntityOpt)) -> Result<Vec<Entity>> . if ids are None all rows are returned from DB.

ListEntityOpt:

enum ListEntityOpt {
    // return all rows from DB.
    All,
    // return rows which in the ids from DB.
    Ids(Vec<i64),
}