liamstask / go-mavlink Goto Github PK

Hi!
I discovered for Travis-CI - mavlink.TestDecode with latest mavlink failed. This is due to increasing the range of enum entry values. I suggest:

1. split mavlink tests for old protocol and latest protocol
2. or fix bytearray in mavlink.TestDecode for compatible with latest mavlink.
   What do you think?

currently, mavgen uses encoding/binary to pack/unpack payload data. this means all data types are treated as interface{}, such that allocations are required to process them. since we know the data types at code generation time, we can provide conversion routines that operate on the concrete types of payload members, which should avoid creating as much garbage as encoding/binary.

furthermore, on packing, could allocate byte slice with the known size of the packet, rather than using a bytes.Buffer, and copy bytes directly into it.