lharri73 / dbc-language-syntax Goto Github PK

[dbc]: language configuration: expected `indentationRules.decreaseIndentPattern` to be a string or an object

from debugger console

This is caused by the 'end' environment being keyed on the end of line character rather than the semicolon. The problem then becomes dealing with strings that are also able to wrap lines, but currently would have to be covered under the '(.*)' pattern which only matches a single line.

This should result in a line number error and continue parsing

So this issue is going to be really nit-picky and is certainly not a must-have for this project. But if you have bandwidth to tackle it, it might be beneficial to have.

File only, single line comments are technically supported in DBC files. These comments are typically not parsed by most commercial applications and more so for documentation purposes inside the DBC file. They are C style comments, so as an example:

// This is a file only comment
BO_ 1234 CANMessage: 8 Node0
    SG_ Signal0 : 0|32@1- (1,0) [0|0] "" Node1 Node2
    SG_ Signal1 : 32|32@1+ (100,0) [0|100] "%" Node1 Node2

BO_ 4321 CANMultiplexed: 2 Node0
    SG_ Multiplexer M : 0|8@1+ (1,0) [0|0] "" Node1
    SG_ Value0 m0 : 8|8@1+ (1,0) [0|0] "" Node1 // I can even do comments after definitions
    SG_ Value1 m1 : 8|8@1+ (1,0) [0|0] "" Node1

CM_ "DBC Template with multiline description";
CM_ BU_ Node0 "The 0th Node";
CM_ BO_ 4321 "Multiplexed CAN-Message";
CM_ SG_ 1234 Signal0 "First signal in this message";

To be very clear when I say 'supported', I mean in an undocumented way. The official Vector DBC specifications don't really outline that file only inline comments are a thing. However, when loading DBC files into Vector's own tool (CANdb++), it will ignore those inline comments and not throw any parsing errors. If you've ever tried to load a malformed DBC into CANdb++, you'll know that it's extremely picky about how items in the file are formatted. Even a minor typo will prevent the file from being parsed and loaded. This leads me to believe that inline comments are intended to be supported for this file format. (note that while // is a supported comment /* is not */

These warnings don't prevent the DBC from being valid, it would be a nice feature to be able to disable them.