lhafkamp / minor-frisbee Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 0.0 975 KB

Assignment for Windmill, a real-time score app for the upcoming ultimate frisbee tournaments.

JavaScript 92.61% HTML 2.14% CSS 5.25%

minor-frisbee's People

Contributors

Stargazers

Watchers

minor-frisbee's Issues

Icons for the nav/voting buttons

Add icons to improve the interface.

Code isn't self-explanatory

It doesn't seem logical that you're selecting the first and third elements. What happende with numbers[1]??
Shouldn't you use a loop or a recursive function here?

minor-frisbee/public/js/io.js

Lines 20 to 21 in 08db932

    
           numbers[0].classList.remove('scoreUpdate'); 
        
           numbers[2].classList.remove('scoreUpdate');

I think you should consider refactoring the HTML first, the second paragraph element, could be a pseude element for example, which makes your HTML cleaner, and your JavaScript more simple

minor-frisbee/views/score.ejs

Lines 18 to 20 in 08db932

    
           <p><%= leftScore || 0 %></p> 
        
           <p>-</p> 
        
           <p><%= rightScore || 0 %></p>

Would be a nice feature but for the time being I left it out. I'm also not sure if this is a great idea because it could mess with the scalability (currently the only websockets that are used are the ones on the score pages).

Logo or shirt color per team

Add a logo or a shirt color icon so that the user knows more than just the team name.

Downfalls:

will have to make more request to the API if I want to get the resource_uri for each team

Remove the game after submitting the final score

Redirect all users back to the main page and remove the game if a final score is set.

Add a web worker

Add a web worker to deal with the slow API requests in the background

Stats on the teams

A feature where you can click on the teams on the score page to see more info about them.

Latest scores from the API on the main page

The main page shows the scores from the app but it currently doesn't retrieve the latest score data if it gets updated in the Leaguevine API.

Success message on submit

Add a success message when submitting the final score. Currently it just redirects to the main page.

Keep your functions lean and mean

Way to much code / functionality for one function

minor-frisbee/public/js/percentage.js

Line 11 in 08db932

function startEvent() {

Line 68 in 08db932

socket.on('upVote', (obj) => {

Use less div elements

Try to make your HTML more semantic

minor-frisbee/app.js

Line 68 in 08db932

socket.on('upVote', (obj) => {

Restructure the DB model

poolData isn't necessary and limits the data use

Use semantic names for variables

'numbers' should be 'scores'?!

minor-frisbee/public/js/io.js

Lines 20 to 21 in 08db932

    
           numbers[0].classList.remove('scoreUpdate'); 
        
           numbers[2].classList.remove('scoreUpdate');

'leftScore' should be '[teamName]Score'?

minor-frisbee/public/js/io.js

Lines 20 to 21 in 08db932

    
           numbers[0].classList.remove('scoreUpdate'); 
        
           numbers[2].classList.remove('scoreUpdate');

Bundle controllers for easier requiring

Instead of requiring all controllers on their own, you can require all the controllers in a main controller file (controller/index.js), and expose them there. So you can require them through one file

minor-frisbee/routes/index.js

Lines 3 to 5 in 08db932

    
           const authController = require('../controllers/authController'); 
        
           const mainController = require('../controllers/mainController'); 
        
           const scoreController = require('../controllers/scoreController');

Scores on the main page

Display on the main page to sync with the latest score.

	numbers[0].classList.remove('scoreUpdate');
	numbers[2].classList.remove('scoreUpdate');

	<p><%= leftScore \|\| 0 %></p>
	<p>-</p>
	<p><%= rightScore \|\| 0 %></p>

	const authController = require('../controllers/authController');
	const mainController = require('../controllers/mainController');
	const scoreController = require('../controllers/scoreController');

lhafkamp / minor-frisbee Goto Github PK

minor-frisbee's People

Contributors

Stargazers

Watchers

minor-frisbee's Issues

Recommend Projects

Recommend Topics

Recommend Org