Invalid invalid type handling about openapi-psr7-validator HOT 7 CLOSED

Also some questions @lezhnev74

This line should some kind of schema validation step, not data validation. It's rather strange to decline data here if schema is invalid. Probably this should go to cebe/php-openapi instead

counting data befor validating its type is unsafe (especially for php 7.2). why we expecting items in data at all?

from openapi-psr7-validator.

Also schema validation is duplicated here

and here

I hope we can leave second only, it's more obvious

from openapi-psr7-validator.

Great points!

1. $this->parentSchema->items.
   Agree, this is too defensive. This should be delegated to the underlying package.
2. count($data) && ! (is_array($data) && ArrayHelper::isAssoc($data))
   This must make sure that the data is an array, and it has no string keys (which makes it a dictionary in terms of JSON). What would be a better check here? Ah, I jsut saw the PR. This code solves the problem: if (! is_array($data) || ArrayHelper::isAssoc($data)) {...
3. Also schema validation is duplicated here.
   Agreed. Let's leave just switch statement here. Again, sometimes my code is over defensive.

from openapi-psr7-validator.

2. everything but counting is ok. counting is unsafe and really not needed. to check vector against array is_array($data) && !ArrayHelper::isAssoc($data) is enough. Counting on non countable would fail in 7.2+

https://php.net/manual/en/migration72.incompatible.php#migration72.incompatible.warn-on-non-countable-types

from openapi-psr7-validator.

For 1 and 3 I can update #21 removing these additional checks

from openapi-psr7-validator.

Please, go ahead, sounds good!

from openapi-psr7-validator.

Done. Raised one more question in PR

from openapi-psr7-validator.