Comments (4)
scaytrase
commented on May 17, 2024
Or we can improve cebe/php-openapi to work with all not eoled yaml
versions, which is not so hard to do
вс, 8 сент. 2019 г., 10:58 Mieszko Malawski <[email protected]>:
… Hi,
Related to #65
<#65> and idea
of moving this package to php league.
I personally believe that in order to spread good practices and allow as
many folks as possible to use openapi validation, we should focus on having
as little dependencies as possible.
Currently, this package uses cebe/php-openapi which forces installation of
symfony/yaml component. This indirectly forces a minimal version of Symfony
and cuts off some potential developers. IMO input source (json/yaml) should
be separated from parsing library. It should be up to developer to parse
yaml/json (symfony/yaml could be a suggestion in composer.json) and then
pass array or stdClass to cebe/php-openapi. This may seem like a bit of
extra effort from developer but it will result in less dependencies and
higher adoption.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#67?email_source=notifications&email_token=ABSGB3J4GWKPDNVQVJAMANLQISWEBA5CNFSM4IUSSTGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJ73FIQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABSGB3IXGNS2I6T23IJS3Z3QISWEBANCNFSM4IUSSTGA>
.
from openapi-psr7-validator.
lezhnev74
commented on May 17, 2024
pinging @cebe
btw, speaking of dependencies. The open PR #64 adds dependency to https://github.com/dflydev/dflydev-fig-cookies which does PSR-7 cookies parsing. Do you think it is excessively?
What would be a go-to strategy to pick which dependencies are allowed and which are better not?
p.s. Another question which remains, what php version we want to support? If #64 gets merged that min requirements move to php 7.2+ instead of 7.1+
from openapi-psr7-validator.
mieszkomalawski
commented on May 17, 2024
dflydev/fig-cookies itself does not have many dependencies so I guess it's fine.
Looking at these stats https://blog.packagist.com/php-versions-stats-2019-1-edition/ about 65% people use 7.2 or above. Still 15% folks using 7.1 would be cut off. I would try to still support 7.1 if it's possible but if it means that some important feature will be blocked then I would consider abandoning 7.1
from openapi-psr7-validator.
digilist
commented on May 17, 2024
PHP 7.1 reaches end of line in 2 months and will not receive any security updates anymore (see https://www.php.net/supported-versions.php), so anybody who is still running 7.1 needs to update urgently.
Imho, PHP 7.1 should only be supported if it does not block any feature development (and also does not complicate it). In all other cases people need to upgrade their PHP version first to use new features.
from openapi-psr7-validator.
Related Issues (20)
- Relative paths in servers objects HOT 9
- Validating non string query parameters HOT 9
- Query string parameter validation of Arrays with `style: form` and `explode: false` HOT 5
- header names are supposed to be case insensitive HOT 1
- Add body validation for "multipart/form-data" requests HOT 3
- Content-Type:application/json with charset HOT 2
- Add parameters serialisation support HOT 1
- multipart with fields without content type won't pass validation HOT 1
- Get the name of the invalid property HOT 11
- Validation of callbacks HOT 6
- Improve urlencoded body parsing
- Add support for PSR-7 `Request` HOT 1
- Bug with oneOf and catch HOT 4
- Bug with numeric strings HOT 3
- Missing inner exception message/detail when using AnyOf/OneOf HOT 4
- Automatically casts numeric strings to integer even if spec says it's a string HOT 6
- Collaboration HOT 15
- Implement complete support for Security schemas
- Strings passes validation against type: number, type: boolean etc.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi-psr7-validator.