Fix failing unit tests about lexikformfilterbundle HOT 9 CLOSED

@Inori these 2 tests are failing since I merged PR #7, so since the bundle use sf2.1. I spent few time on it but I didn't find any solution too.

from lexikformfilterbundle.

@cedric-g can you give an ETA when you'd get some time to review this issue in depth?

from lexikformfilterbundle.

@Inori I should have some time on friday afternoon except if we are in late on our current project.

from lexikformfilterbundle.

I've looked more deeply into it, seems that you don't get child data via $form->getData() anymore (empty array here )
Only way to get children data in that situation is to iterate through children and call ->getViewData(), but you can't use that either since it's just the passed data from the test. I assume that ->getNormData() is the one we need but it always returns null for me..

I can't figure out if this is bundle problem or symfony2 bug :/

from lexikformfilterbundle.

I fixed this one:

Lexik\Bundle\FormFilterBundle\Tests\Filter\QueryBuilderUpdaterTest::testBuildQuery
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'SELECT i FROM Lexik\Bundle\FormFilterBundle\Tests\Fixtures\Entity i WHERE i.name LIKE '%blabla' AND i.position <= 2 AND i.createdAt = '2013-09-27''
+'SELECT i FROM Lexik\Bundle\FormFilterBundle\Tests\Fixtures\Entity i WHERE i.name LIKE '%blabla' AND i.position <= 2'

but the test with the date range is still failing :(

from lexikformfilterbundle.

It's not really a fix ^^ but I just changed the date range test to make it work, I didn't use the single_text options anymore.

from lexikformfilterbundle.

Haha yeah not really a solution - I tried that btw, we will still have problems down the road when implementing #13.
I had an idea yesterday - maybe data isn't transformed because we're not mapping the type to a model? (which can be a POPO class with couple of variables and getters setters)
I mean, there's a reason why transformers we need are bound to modelTransformers array :D

from lexikformfilterbundle.

Good news! After #17 is merged, there's only one error left:

There was 1 error:

1) Lexik\Bundle\FormFilterBundle\Tests\Filter\QueryBuilderUpdaterTest::testBuildQuery
Symfony\Component\Form\Exception\UnexpectedTypeException: Expected argument of type "string", "array" given

// ...
...\Tests\Filter\QueryBuilderUpdaterTest.php:92
// ...

from lexikformfilterbundle.

I just updated the tests to use SF2.1.0-RC2 and I fixed an error in the NumberFilterType. Now all tests seems ok.

from lexikformfilterbundle.