Comments (9)
@Inori these 2 tests are failing since I merged PR #7, so since the bundle use sf2.1. I spent few time on it but I didn't find any solution too.
from lexikformfilterbundle.
@cedric-g can you give an ETA when you'd get some time to review this issue in depth?
from lexikformfilterbundle.
@Inori I should have some time on friday afternoon except if we are in late on our current project.
from lexikformfilterbundle.
I've looked more deeply into it, seems that you don't get child data via $form->getData()
anymore (empty array here )
Only way to get children data in that situation is to iterate through children and call ->getViewData()
, but you can't use that either since it's just the passed data from the test. I assume that ->getNormData()
is the one we need but it always returns null
for me..
I can't figure out if this is bundle problem or symfony2 bug :/
from lexikformfilterbundle.
I fixed this one:
Lexik\Bundle\FormFilterBundle\Tests\Filter\QueryBuilderUpdaterTest::testBuildQuery
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'SELECT i FROM Lexik\Bundle\FormFilterBundle\Tests\Fixtures\Entity i WHERE i.name LIKE '%blabla' AND i.position <= 2 AND i.createdAt = '2013-09-27''
+'SELECT i FROM Lexik\Bundle\FormFilterBundle\Tests\Fixtures\Entity i WHERE i.name LIKE '%blabla' AND i.position <= 2'
but the test with the date range is still failing :(
from lexikformfilterbundle.
It's not really a fix ^^ but I just changed the date range test to make it work, I didn't use the single_text
options anymore.
from lexikformfilterbundle.
Haha yeah not really a solution - I tried that btw, we will still have problems down the road when implementing #13.
I had an idea yesterday - maybe data isn't transformed because we're not mapping the type to a model? (which can be a POPO class with couple of variables and getters setters)
I mean, there's a reason why transformers we need are bound to modelTransformers
array :D
from lexikformfilterbundle.
Good news! After #17 is merged, there's only one error left:
There was 1 error:
1) Lexik\Bundle\FormFilterBundle\Tests\Filter\QueryBuilderUpdaterTest::testBuildQuery
Symfony\Component\Form\Exception\UnexpectedTypeException: Expected argument of type "string", "array" given
// ...
...\Tests\Filter\QueryBuilderUpdaterTest.php:92
// ...
from lexikformfilterbundle.
I just updated the tests to use SF2.1.0-RC2 and I fixed an error in the NumberFilterType
. Now all tests seems ok.
from lexikformfilterbundle.
Related Issues (20)
- Mongo as separate packages? HOT 2
- v5.0.9 Broken with symfony 3.4 HOT 2
- Service "lexik_form_filter.query_builder_updater" not found HOT 4
- doctrine/orm v2.6.4 has issues with using ChoiceFilterType with objects
- NumberRangeFilterType can not set attribute " type:'number' '' , and 'label' is not work as well HOT 3
- CollectionAdapterFilterType display an unwanted "level" with a label : "0" HOT 2
- Store Entity in session HOT 1
- Not a issue, change repo description HOT 1
- How to have more user/search engines friendly urls
- Works in symfony 5.1 ? HOT 1
- How to add a field to set maxresults HOT 1
- Options 'data' does not work for EntityFilterType
- Hi HOT 3
- Undefined class constant 'INTEGER' when filtering EntityFilterType HOT 2
- doctrine/orm to specific HOT 1
- Using ChoiceFilterType generate: Undefined constant Doctrine\DBAL\Types\Type::STRING HOT 1
- Ltrim issue in LexikFormFilterBundle/Event/Subscriber/DoctrineORMSubscriber.php
- Filter by entity with string id HOT 3
- Feature Request: Allow using array based $parameters with IN() expressions HOT 2
- Bundle abandonned...and moved on new organization!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lexikformfilterbundle.