Feature Request: Allow using array based $parameters with IN() expressions about lexikformfilterbundle HOT 2 OPEN

I found another workaround: Instead of setting an array as the parameter value, I can keep as/convert to an ArrayCollection, so that is_array() branch in DoctrineApplyFilterListener does not apply at all. I don't know if that works in all cases and it is not how Doctrine handles parameters on in() expressions, but in my case that works well:

->add('myfield', EntityFilterType::class, [
    // ...
    'class' => MyEntity::class,
    'multiple' => true,
    'apply_filter' => function (QueryInterface $filterQuery, string $field, array $values): ?ConditionInterface {
        // ...
        // $values['value'] already is an ArrayCollection in that context (EntityFilterType with multiple option set to true)
        return $filterQuery->createCondition(
            $filterQuery->getExpr()->in($field, ':p_myparam'),
            ['p_myparam' => $values['value']->map(fn(MyEntity $value) => $value->getId()->toBinary())]
        );
    },
])

Nevertheless: I'll provide a PR on that topic soon that makes that part of the code more clean and introduces a ExpressionParameterValue class that holds a parameter value for an expression and optionally its type in a clean way. So that that old and ambiguous handling of array-values can be deprecated in favor of that ExpressionParameterValue value object.

from lexikformfilterbundle.

This is closely related to #362 in a way that it only came up for me, because that default implementation of the EntityFilterType cannot handle non-integer primary keys. So that also could be fixed for those standard cases of the EntityFilterType without an additional 'none' option that at the moment must be handled by a ChoiceFilterType anyway.

from lexikformfilterbundle.