leuchtfeuer / mautic-deutschepost Goto Github PK

Describe the bug
Das Print-Mailing ist im Status 'Aktiv'. Um eine Änderung vorzunehmen, pausieren Sie es zunächst. at (path)/plugins/MauticTriggerdialogBundle/Service/TriggerdialogService.php:330)"} {"hostname":"mautic2","pid":1614443}

Expected behavior
This should NOT lead to Error 500 but display a message in the Mautic UI. Ideally, Same for any other messages that are returned from DPAG

Mautic version

Additional context
Add any other context about the problem here.

Describe the bug
We tried to send a mailing with mapping fields from contacts and their corresponding primary company fields. All fields had a value, however when trying to send a campaign it failed.
Error Message: " Letzter Ausführungs-Fehler: Das Feld darf nicht null sein."

We manually checked, that we didn't have any empty fields. Unfortunately the error message doesn't give more details about where the error occurred. Deutsche Posts confirmed, that no data has been received. Thus its probably the plugin internal validation, that stopped the sending.

To Reproduce
Steps to reproduce the behavior:
Create a print mailing campaign and map fields from contact and primary company.

Expected behavior
I should be able to use fields from the contact directly, but also from the corresponding primary company.

Screenshots

Mautic version

• Version Mautic: 3.2.5 / Plugin: 2.0.0

Describe the bug
I try to delete my "test" Print Mailing Templates. However, they can't be deleted. Not as admin (all rights), also not as user with the delete right explicitly granted.

To Reproduce
Steps to reproduce the behavior:

1. create a template
2. try to delete it

Expected behavior
should be deleted

Screenshots
log: [2022-03-25 17:36:00] mautic.CRITICAL: Uncaught PHP Exception MauticPlugin\MauticTriggerdialogBundle\Exception\RequestException: "Zugriff auf die Ressource verweigert. Nicht genügend Berechtigungen." at MASKED/httpdocs/plugins/MauticTriggerdialogBundle/Service/TriggerdialogService.php line 169 {"exception":"[object] (MauticPlugin\MauticTriggerdialogBundle\Exception\RequestException(code: 1605089193): Zugriff auf die Ressource verweigert. Nicht genügend Berechtigungen. at MASKED/httpdocs/plugins/MauticTriggerdialogBundle/Service/TriggerdialogService.php:169)"} []

Mautic version
4.2

If I remove the triggerdialog plugin from inside the directory and after I deleted the /cache/* I got the following errors in the logfile:

Symfony\\Component\\Debug\\Exception\\ClassNotFoundException: Attempted to load class "ConfigSubscriber" from namespace "MauticPlugin\\MauticTriggerdialogBundle\\EventListener".\nDid you forget a "use" statement for e.g. "Mautic\\QueueBundle\\EventListener\\ConfigSubscriber", "Mautic\\EmailBundle\\EventListener\\ConfigSubscriber", "Mautic\\CoreBundle\\EventListener\\ConfigSubscriber", "Mautic\\AssetBundle\\EventListener\\ConfigSubscriber", "Mautic\\SmsBundle\\EventListener\\ConfigSubscriber", "Mautic\\CampaignBundle\\EventListener\\ConfigSubscriber", "Mautic\\ApiBundle\\EventListener\\ConfigSubscriber", "Mautic\\ConfigBundle\\EventListener\\ConfigSubscriber", "Mautic\\ReportBundle\\EventListener\\ConfigSubscriber", "Mautic\\UserBundle\\EventListener\\ConfigSubscriber", "Mautic\\PageBundle\\EventListener\\ConfigSubscriber", "Mautic\\LeadBundle\\EventListener\\ConfigSubscriber", "Mautic\\WebhookBundle\\EventListener\\ConfigSubscriber", "MauticPlugin\\MauticSocialBundle\\EventListener\\ConfigSubscriber" or "MauticPlugin\\MauticLdapAuthBundle\\EventListener\\ConfigSubscriber"? - in file /app/code/vendor/symfony/event-dispatcher/ContainerAwareEventDispatcher.php - at line 138

The whole site is offline till i put the plugin back into to plugin folder. Do you have an advice for me how to uninstall the plugin?

e.g. in local.php , database, file names, classes, ...

mautic-deutschepost plugin doesn't work with Mautic 3 (3.0.1)

It fails with:

Class "Mautic\CoreBundle\EventListener\CommonSubscriber" not found while loading "MauticPlugin\MauticTriggerdialogBundle\EventListener\ConfigSubscriber".

Reason:
CommonSubscriber removed. Implement Symfony\Component\EventDispatcher\EventSubscriberInterface directly and use DI instead.

(from: https://github.com/mautic/mautic/blob/8cb3c509a09224fe9c71abe84faebdb69c11c934/UPGRADE-3.0.md)

Describe the bug
With the latest changes the app does not start anymore. We receive a 500er.

To Reproduce
Steps to reproduce the behavior:

1. Get the latest code changes on master branch
2. Clear the cache
3. Open the app

Expected behavior
See the login screen

Screenshots
Error: Class ‘MauticPlugin\LeuchtfeuerPrintmailingBundle\Generator\ClientIdGenerator’ not found - in file /var/www/html/plugins/MauticTriggerdialogBundle/Config/config.php - at line 134

Mautic version
4.4.6

Describe the bug
triggerdialog_rest_password and triggerdialog_masSecret get NULLed when I save anything in the configuration UI

To Reproduce
Steps to reproduce the behavior:

1. Start with a working installation, or create one by entering all data in configuration -> Print Mailing Settings
2. check the data in local.php
3. Now change anything in configuration -> Print Mailing Settings (e.g., for testing, change the REST API user name
4. As a result, we now have deleted the secrets in local.php
   'triggerdialog_masSecret' => null,
   'triggerdialog_rest_password' => null,

Expected behavior
secrets must not be displayed in the UI, but must remain intact in local.php

Mautic version
4

Additional context
Porbably related to #21

For some unknown reason, update to 4.2.1 invalidates the plugin authentication:
In the "Print Mailing" menu item, a yellow box message
Your configuration seems to be invalid. Please check your [Configuration]
is displayed.

Solution: Go to Configuration -> Print Mailing Settings
and re-enter Prod JWT Token as well as Authentication Secret

This will fix the issue.

(Root cause currently not investigated.)

Is your feature request related to a problem? Please describe.
I tried to install the plugin with Mautic 5 upwards

With Mautic 5.0.4 I got the following errors:

Error in browser:
The "app/bundles/CoreBundle/Resources/views/Offline" directory does not exist ("//app/bundles/CoreBundle/Resources/views/Offline").

Error in logs:
PHP Fatal error: Declaration of MauticPlugin\LeuchtfeuerPrintmailingBundle\LeuchtfeuerPrintmailingBundle::onPluginUpdate(Mautic\PluginBundle\Entity\Plugin $plugin, Mautic\CoreBundle\Factory\MauticFactory $factory, $metadata = null, ?Doctrine\DBAL\Schema\Schema $installedSchema = null) must be compatible with Mautic\PluginBundle\Bundle\PluginBundleBase::onPluginUpdate(Mautic\PluginBundle\Entity\Plugin $plugin, Mautic\CoreBundle\Factory\MauticFactory $factory, $metadata = null, ?Doctrine\DBAL\Schema\Schema $installedSchema = null): void in /var/www/html/mautic/docroot/plugins/LeuchtfeuerPrintmailingBundle/LeuchtfeuerPrintmailingBundle.php on line 12

I played a little bit with the permission settings in mautic. On that this pops up. Is this a part on my side or is this a missing "feature" in triggerdialog?

[2019-12-11 18:56:26] mautic.CRITICAL: Uncaught PHP Exception InvalidArgumentException: “Permission class not found for triggerdialog in permissions classes” at /app/bundles/CoreBundle/Security/Permissions/CorePermissions.php line 128 {“exception”:"[object] (InvalidArgumentException(code: 0): Permission class not found for triggerdialog in permissions classes at /app/code/app/bundles/CoreBundle/Security/Permissions/CorePermissions.php:128)"} [2019-12-11 18:56:38] mautic.ERROR: InvalidArgumentException: Permission class not found for triggerdialog in permissions classes - in file /app/bundles/CoreBundle/Security/Permissions/CorePermissions.php - at line 128

Describe the bug
I tested Mautic with PHP upgraded to 8.0. System didn't work then...
We use the most current version of the PMA Plugin (4.1)

To Reproduce
Steps to reproduce the behavior:

1. Set your webenvironment to PHP 8.0

Expected behavior
Should not crash Mautic.

Mautic version
4.4.3

Additional context

Log output:

[2022-11-08 08:50:58] mautic.ERROR: PHP Notice: Unparenthesized a ? b : c ?: d is not supported. Use either (a ? b : c) ?: d or a ? b : (c ?: d) - in file /httpdocs/plugins/MauticTriggerdialogBundle/Controller/TriggerCampaignController.php - at line 421 [] {"hostname":"","pid":29930}
[2022-11-08 08:50:58] mautic.ERROR: Symfony\Component\Debug\Exception\FatalErrorException: Notice: Unparenthesized a ? b : c ?: d is not supported. Use either (a ? b : c) ?: d or a ? b : (c ?: d) - in file /httpdocs/plugins/MauticTriggerdialogBundle/Controller/TriggerCampaignController.php - at line 421 [] {"hostname":"","pid":29930}

Describe the bug
Triggerdialog config link won't respect the subdirectory where Mautic is installed.
E.g. https://MAUTICDOMAIN/s/config/edit#triggerdialogconfig instead of https://MAUTICDOMAIN/go/s/config/edit#triggerdialogconfig

Mautic version
3.1.2

Additional context
minor issue, just want to make sure there are no other references to mautic path which may break the plugin to work correctly

Describe the bug
Error 500 with log messages like these show up
500 Internal Server Error - Es existiert bereits ein Print-Mailing mit dem externen Bezeichner "6".
500 Internal Server Error - Ein Datensatz konnte nicht gefunden werden: 0.
Es existiert bereits ein Print-Mailing mit diesem Namen.

Situations where these occur:

• The same DPAG account is (or has been) used by multiple instances
• Things have been deleted on the Mautic side but not on the DPAG side
• The DPAG account has been changed in this Mautic
• a user is giving the same name twice

Expected behavior

• For Print Mailing Templates in Mautic, Mautic should not allow the same name twice
• Before persisting a Print Mailing, Mautic should verify if that name exists, and if so: deny usage and remain in creation form ("name already exists in DPAG, please choose a different one")
• Before persisting a Print Mailing, Mautic should verify if the intended ID , and if so: Increase by one and try again

Ideally, Mautic should be able to fetch all existing print mailings and add all missing ones to the List of Print Mailings (mark them as "imported; needs mapping verification"). But that's not for here; I'll create a different story :)

Mautic Plugin version
4.4

Plugin version
4.1

Describe the bug
When I enter the "Prod JWT Secret" and the "Authentication Secret" and save them, they are shown in plain text. This allows any user of the instance with access to the settings to just copy them out and use them for unwanted purposes.

To Reproduce
Steps to reproduce the behavior:

1. Enter secrets
2. Save
3. Secrets are visible

Expected behavior
I would expect that a "password" style field would be used for the secrets so they are not shown in the interface and cannot be copied out.

Screenshots