lettertwo / atom-narrow-provider-diagnostics Goto Github PK

I noticed this from GIF, where updating indicator (x icon) remain running state.

This is because ProviderBase.protototype.finishUpdateItems is not called.
Updating items must be finalized to notify narrow-ui to finish updating.

Basically you have two pattern to finalize

• Option-1:

  • finishUpdateItems(items): Use this if you update items in single response against request from UI.

• Option-2:

  • updateItems(items): You can update(render) items multiple times against single request.
  • finishUpdateItems(): Then finalize with empty arg.

Why narrow provide option-2 is, search provider collect items on each data event of event emitter which is emitted multiple-time.
So when you search foo, the result is updated separately on each data event.
This prevent big items consume huge heap memory and blocking event-loop long-time while preparing new item-list on UI.