leoletellier / slbl-fsa Goto Github PK

The indication of the theta angle slide 16 in the PDF documentation seems false.
This angle is the incidence angle, which can be considered equal to the off-nadir angle (Chapter 1 SAR Imaging basics, NASA, pp A5 - A6) and is defined as "angle between the vertical direction and the radar wave
propagation vector" (InSAR Principles: Guidelines for SAR Interferometry Processing and Interpretation, ESA, 2007, pp 5).
Thus it is not defined between the LOS and the horizontal axis, but rather between the LOS and vertical axis.

The Python files seem te be implementing the correct convention.

hi,
thank you for your great tool!
Just small fix for error regarding the example project dem and disp files:
change absolute paths to relative paths, so
SFA.bat can read:
DEM_PATH example/dem.csv
DISP_PATH example/disp.csv

The function to save the model saves also the comparison with sar data, so that this comparison must be computed for the data to be saved. However there is no mechanism to stop the user from trying to save before computing the comparison, and no alternative to save only the result of the model.

When comparing the model results with sar displacement, the method with least squares seems to be implemented in the way that the displacement obtained by the model must be positive, thus not matching negative sar displacement.

Harmonize the scale of the model and insar arrows for better visualisation.
Perhaps display from a single array to get a single matplotlib automatic scale, and add unit vector for scale.