leocavalcante / siler Goto Github PK

in composer.lock

The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.

Posted from SensioLabsInsight

The line 239 have $_SESSION['lang] where it should be $_SESSION['lang'].

I'd like to avoid opening a PR just for that, could you correct that typo ?

Also, switching '' with "" line 248, so Github syntax coloration is happy !

I red this tutorial : https://siler.leocavalcante.com/graphql/subscriptions.html#starting-the-server

It sounds good but you didn't write about some possible problems with the server (exemple : after the server restart). Is it necessary to install a supervisor like http://socketo.me/docs/deploy#supervisor
And if you don't have a possibility to use a supervisor (shared hosting) , is it possible to check every time with a cron task and restart the server if necessary?

PHP Deprecated: GraphQL\GraphQL::execute is deprecated, use GraphQL::executeQuery()->toArray() as a quick replacement in /var/www/html/siler-graphql/vendor/webonyx/graphql-php/src/GraphQL.php on line 187

Need to change on https://github.com/leocavalcante/siler/blob/master/src/Graphql/Graphql.php#L91

return GraphQL::execute(
        $schema,
        $query,
        $rootValue,
        $context,
        $variables,
        $operation
    );

to

return GraphQL::executeQuery(
        $schema,
        $query,
        $rootValue,
        $context,
        $variables,
        $operation
    );

in docs/concepts.md, line 41

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

* [Object-Oriented Programming is Bad - Brian Will](https://www.youtube.com/watch?v=QM1iUe6IofM)
* [Stop Writing Classes - Jack Diederich](https://www.youtube.com/watch?v=o9pEzgHorH0)
* [Advanced OOP in Elixir - Wojtek Mach](https://www.youtube.com/watch?v=5EtV2JUU0Z4) *(spoiler - is an ironic talk)*
* [Was object-oriented programming a failure? - Wouter van Oortmerssen](https://www.quora.com/Was-object-oriented-programming-a-failure/answer/Wouter-van-Oortmerssen)

Thank you.

Posted from SensioLabsInsight

Hi Leo,

Yesterday, I tried to use Siler with Swoole. It's great. Alas, I can't access GET or POST params when I used files base route.

index.php

Route\get('/3', 'controller.php', Swoole\cast($req))

controller.php

var_dump($params) // array for route [0] => 3
var_dump($req, $res) // error
var_dump(\Siler\Http\Request\get()) // null

Is there any way to access it?

We can split siler plugins into its own repository. I know it's sound silly to make repo for tiny source code, but it will make dependency more implicit.
As example, if we require twig functionality, we simply require siler/twig and composer will do the job to install twig/twig too.

now zendframework/zend-diactoros without emit, but zendframework/zend-httphandlerrunner have it.
it will be great to add emitting psr-7 responce to framework

great job!
thanks

in tests/Ratchet/RatchetTest.php, line 7

The class Siler\Ratchet\MessageComponent is declared but never used. You should remove the use statement.

namespace Siler\Test;

use Siler\Container;
use Siler\Ratchet;
use Siler\Ratchet\MessageComponent;
use Ratchet\ConnectionInterface;

class RatchetTest extends \PHPUnit\Framework\TestCase
{
    public function testConnected()

Posted from SensioLabsInsight

in src/Graphql/Graphql.php, line 82

The parameter info, which is an object, should be typehinted.

 *
 * @param $resolvers
 */
function resolvers(array $resolvers)
{
    Executor::setDefaultFieldResolver(function ($source, $args, $context, $info) use ($resolvers) {
        if (array_key_exists($info->parentType->name, $resolvers)) {
            $subject = $resolvers[$info->parentType->name];

            if (is_callable($subject)) {
                $subject = $subject($source, $args, $context, $info);

Posted from SensioLabsInsight

Hi,

I am curious how we can implement authentication when subscribing on GraphQL, with the example, anyone who knows the roomName can subscribe to the websocket endpoint.

More functional abstractions!

• Callable to filter by is_null and/or empty
• Partial-application

This is another request for enhancement. Basically once the project becomes marginally larger it becomes cumbersome to specify all routes.

As a viable alternative I would suggest a controller method. It would bind the routes to controller methods automatically based on verbs.

Some implementations of the above:
https://github.com/lesichkovm/laravel-advanced-route
https://github.com/mrjgreen/phroute

Functions to perform on String operations

• Slugify
• Cross-platform break-lines

For development, the composer serve script works well, but for production, it's better to run the PHP server with something like a NGINX server or an Apache server.

I looked a it in the library's source code but didn't find any clue on how to make a valid Apache2 configuration to use the index.php entry point file (with for example a code like below).
Could you make an example configuration or a small documentation page ?

<?php
error_reporting(E_ALL);
ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);

// Requiring composer deps
require_once ('./vendor/autoload.php');

use Siler\Route;
use Siler\Functional as f;

Route\get('/m', f\puts('Meow'));
Route\get('/v', f\puts('Time is '.time()));

Hi @leocavalcante,

Is it possible to make use of psr-15 middlewares -https://github.com/middlewares/psr15-middlewares ? If so, can you make a brief example?

Highly interesting framework and concepts. Thanks for sharing.

Hello,

I have followed graphQL example from docs https://siler.leocavalcante.com/graphql/ but it doesnt work to me. When I run GraphiQl with:

query {
  rooms {
    id
    name
  }
}

I get following result:

{
  "errors": [
    {
      "message": "Syntax Error GraphQL (1:1) Unexpected <EOF>\n\n1: \n   ^\n",
      "category": "graphql",
      "locations": [
        {
          "line": 1,
          "column": 1
        }
      ]
    }
  ]
}

I have installed all the dependencies (composer.json).

{
  "require": {
    "leocavalcante/siler": "dev-master",
    "webonyx/graphql-php": "^0.11.5",
    "gabordemooij/redbean": "^5.0"
  }
}

There isnt any error in apache/error log. What could be causing the problem?

DocBlock @return has no type at https://github.com/leocavalcante/siler/blob/master/src/Http/Response.php

in examples/react-http/baz.twig, line 10

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

  <title>Siler + ReactPHP rocks!</title></head><body><p>Thanks to PSR interop.</p></body></html>

Posted from SensioLabsInsight

Calling a non-static method using the default callable implementation always causes the constructors to be called, which is undesirable. See in the example below even if you call the / route, the execution will be stopped as the constructor in test will be called.

class TestController {
    function __construct() {
         if (has_access() == false){
             die('No Access');
         }
    }
    function page() {
        return "Page A";
    }
}
Route\get('/user', [(new TestController), "page"]);
Route\get('/', function(){
    return "Home";   
});

I would suggest a workaround for calling non-static methods

Route\get('/user', "TestController@page");

Return value of Siler\Swoole\raw() must be of the type string, bool returned

When using siler for a website, and assuming the request is only sent by a form using either application/x-www-form-urlencoded or multipart/form-data, PHP parses the request body and populates the $_POST variable with parse results.

If it doesn't recognise the Content-Type of the request or if it's incorrectly set, PHP will fail to parse without a warning and will only give an empty $_POST.

Such behaviour would be expected when using Siler as a backend API, receiving and sending back JSON (e.g. with the JSONP request format).

For that, the trick is to read from php://input but that can only be done 1 time (source). For now, the Request::raw method does the trick, but only one time.

I'll work on the Request.php file to add lazy retrieving/global storing to avoid data loss when reading multiple times.

in .gitignore, line 5

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

/*.phar
/vendor/
/coverage-*
/examples/
/.idea/

Posted from SensioLabsInsight

Package leocavalcante/siler at version has a PHP requirement incompatible
with your PHP version (5.6.27)

how to deal with this error?

Hi, either in Siler\Request or Siler\Diactoros it is possible to get the URI param (using Route\resource), I just tried THE PUT verb : PUT | /users/{id} | update.php
Anyway i did that :

$id = explode('/', \Siler\Diactoros\request()->getServerParams()['REQUEST_URI'])[2];

Is there an other possibility ?
Thanx, Great work by the way.

EDIT:
I just figured out :
I put $id = array_get($params, 'id') in any controller and it works, i don't where this "global variable" come from but it works.

in src/Graphql/Graphql.php, line 13

The class Exception is declared but never used. You should remove the use statement.

use Siler\Http;
use Siler\Http\Request;
use Siler\Http\Response;
use GraphQL\Schema;
use GraphQL\GraphQL;
use \Exception;
use function Siler\array_get;

/**
 * Initializes a new GraphQL endpoint
 *

Posted from SensioLabsInsight

He's remove them and we have bug in Siler\Diactoros

I have installed this in a subfolder and I am getting this error

Parse error: syntax error, unexpected '(' in /Users/XYZ/Work/htdocs/project/vendor/leocavalcante/siler/src/Functional/Functional.php on line 113

This error comes when I access site like http://localhost/project/

But when I do composer serve site works fine over http://localhost:8000/

I have to put this on a shared hosting where I can not run composer serve

Some tools do not work well with Unicode characters, and these get translated to "?" (see screenshot). Proposal is to change it to an ASCII character (probably low case L)

Everytime I call any Siler endpoint, it got logged to console like this:
[Sat Jan 12 22:49:53 2019] 127.0.0.1:54408 [200]: /healthCheck

I'd like to understand where it is comming from, is there any way to turn it off, change formatting or so? Is there an implementation of logging interface somewhere in Siler, can we use it too?

Notes:

1. I'm using compose serve to serve.
2. Pls excuse me if these questions are dumb, lost contact with PHP decade ago 😉

in .gitignore, line 5

/.idea/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

/*.phar
/vendor/
/coverage-*
/examples/
/.idea/

Posted from SensioLabsInsight

in src/Graphql/SubscriptionManager.php, line 9

The class Siler\Graphql is declared but never used. You should remove the use statement.

use GraphQL\Language\AST\DocumentNode;
use GraphQL\Language\Parser;
use GraphQL\Schema;
use Ratchet\ConnectionInterface;
use Siler\Graphql;
use function Siler\array_get;

class SubscriptionManager
{
    protected $schema;

Posted from SensioLabsInsight

I like your project and approach to design.
when can we expect a release?
it would be good to introduce boilrplate to framework's recommended directory structure (like lumen or so)..

How to POST json data using SILER?

Seems it's not compatible with php 7.0

What are the minimum requirements?

Refactoring needed for subscriptions

Planning to drop Ratchet support in favor of explicit using Thruway instead, which is already simple to use and creating a wrapper to it is unnecessary.

in src/Route/Route.php, line 141

This ext local variable is declared but never used. You should remove it.

    $filename = str_replace('\\', '/', $filename);
    $filename = trim($filename, '/');
    $filename = str_replace('/', '.', $filename);

    $tokens = explode('.', $filename);
    $ext = array_pop($tokens);
    $method = array_pop($tokens);
    $path = implode('/', $tokens);
    $path = '/'.trim(str_replace('index', '', $path), '/');

    return [$method, $path];

Posted from SensioLabsInsight

Hi, can we make siler cache repetitive function result ?
Example: Http\path always get called when use Route\route.
Imagine if we use Route\files and there is hundreds of file inside the $basePath.

Siler is fast, and I think we can make it faster a bit. :)

If someone tries to do a Siler\Http\Request\json() when the request body is empty, the json_decode will fail (and return null), and the array type enforcing will fail, thus throwing a TypeError.

An example message is:

Fatal error: Uncaught TypeError: Return value of Siler\Http\Request\json() must be of the type array, null returned

Can we have a helper method called any:

Route\any('/path', <handler>);

Is there a way to pass request and params to object/method?

As a method call using PHP's array notation:

use Siler\Route;

class Hello {
  public function method() {
    echo 'Hello Array Notation';
  }
}

$obj = new Hello();
Route\post('/', [$obj, 'method']);

What I want to do:

Route\post('/blog/{id}', ['App\Controllers\Blog', 'update']);

App\Controllers\Blog.php

<?php
namespace App\Controllers;

class Blog
{
    public function update(Request $request)
    {
        echo $request->id;
    }
}

I mean, there is a way to inject params into method or any other way to access route params inside controller/method function?

BTW, shining job 👏
Congratz and thank you

There is no tests for Siler\Ratchet\init, weirdly is it passing by Codecov, but not by PHP Unit coverage report.

Hello,
In a route resource, the path "/create" will also call show.php because it will match "/{id}".
You have to either "exit();" in create.php, or "if ("create" == $params['id']) { return; }" in show.php.
Any idea to make it work without the workarouds ?

Hello,

Can you help, please...
In case request undefined route - Siler response empty body with 200 code.

But how to define 404 error for incorrect/undefined route?