Most logs are, I think, done (very simply). There may be a loophole according to when the player meets Benjamin Downey, that might miss out a log on him.

Luxury outfits in vanilla function across all ships if they are in the cargo hold or installed in flagship, and not if installed in another ship. AFAIK this is no worse here than in standard use in vanilla, except that it's required in story so might stand out a little more.

I am amused, though, flying my Flivver around with a luxury outfit and personal staff to wait on my - the pilot's - every need... while the 300 passengers on the overcrowded Kimek Spire flying behind pay a premium because they saw 'luxury' in the brochure.

An about.txt will give users an in-game description for the purpose of your plugin. You should keep this description short because the UI does not support text overflow or text scrolling.

cf endless-sky/endless-sky#6133

It might be necessary and/or worthwhile to update the wormhole creation/removal logic according to the added vanilla feature (above)

From endless-sky/endless-sky#5766:

Given that the description of the Barb specifically calls out the fact that the Syndicate does not produce a carrier, I think that the Class C Protector would make an excellent mission ship to have unlocked at some point during the Syndicate campaign. Perhaps have an up-armored, up-shielded carrier version of the Protector that unlocks at roughly the same point in the Syndicate campaign as the Dreadnought in the FW story, and presumably around the same point as when the Carrier would be unlocked in the Navy campaign.

There are still compatibility relics from half-complete versions of the plugin. Check if any need keeping, and put in appropriate place

Need to check for compatibility issues following the FW storyline rework.

Things that still work here (and don't break anything otherwise) but are now a little different from how FW story plays out, are lower priority.

vanilla logic changed in 0.9.16 so accompany doesn't automatically require save. Need to add were appropriate here.

There are several features in vanilla that are referenced by the mission name, that can break if e.g. FW missions are reworked. If this plugin were to become part of vanilla, those hooks should be amended to generic events or stored data that represents actually what's being queried.

Such changes could be helpful in vanilla anyway, to make it more robust for other plugins and for future vanilla content.

There are some notes of these in the Notes files in the plugin.

You have disclosed your license which is generally okay but it is more standard for you to include the full license text. It helps contributors quickly know the license used. I can open a pull request for this.

I noticed some issues with the new hai reveal campaign assuming you did free worlds. One part is explicitly commented that this assumption is made (Hai Leaks Response 2A). There is also a part congratulating you for fighting the pug (Hai Leaks Response 2), likely assuming that "pug attack" = "you fight pug" which isn't actually always true in ScS. There are likely other issues stemming from this as well. I recommend reading through hai reveal, especially the intro missions, and looking to see where such problems occur.

The plugin index makes plugins easily found by endless sky players

You can view the index here.

The following is an example of me opening a pull request for one of my own plugins. It would also make it available for automatic installation by users of ESLauncher2 which is a game launcher for endless sky.

endless-sky/endless-sky#3746

affects a few points in these missions.

Interest rates in vanilla display between 0.1%-1%. outside of that range formats as if it were in that range.

The copyright file covers all files in your repository. It both gives attribution and enables other to copy your work into the vanilla game because they know who authored which files and under what license each file falls. Refer to the upstream endless-sky repository for a big example of copyright.

main is now a fairly standard name for branches on GitHub repos.

Want to eventually have a story branch parallel to FWCheckmate.

Files are arranged for the plugin, and may need different naming scheme for the vanilla game. Want to sort this out to be easy to develop in plugin then copy over to a vanilla branch for PR

The intro is prefixed SC ___; all the rest is SCS ___. If joining to vanilla, these should be consistent, and probably something like CiM ___ (Crisis in Management) to avoid confusion with a main Syndicate storyline.

More epilogues for visiting people you interacted with in game. Most have stub missions commented out at the end.

• Also to visit the rescued fugitives on Winter

Need to update copyright file in vanilla PR for mini-wormhole image

should have the missions affect syndicate reputation

If not do you mind someone else doing it while preserving your authorship?

Combat is not balanced. Most significant is probably the Korath battle, that ideally needs the pilot's help to succeed, but not too much help necessary.

Should have an espionage job for Delta V - Solace/Pherkad

Could also have some espionage or similar jobs offered by WC during the appropriate time.

There's a couple of times, I think, where you can let your passenger die and the failed mission just leads to a branch.

• Taking the anti-union advisors, and choosing whether to bring them on time, or late ...or 'late'!
• Maybe in Abduction 2b, in Rescue phase