Code Monkey home page Code Monkey logo

movierank's Introduction

Hi there 👍

movierank's People

Contributors

leejoobang avatar

Watchers

 avatar  avatar

movierank's Issues

이미지 처리

현재 pagenation 처리를 하며 이미지를 보여주고 있음.
그러나 페이지를 빠르게 넘길 때 이미지 표시에 딜레이 발생함.
이부분에 대한 해결이 필요함.
-> 해당 이슈의 경우 이미지 캐싱으로 처리할 것으로 계획함.

  • Kingfisher 적용

TDD 적용

  • Test Code 작성
    • 1. 결합도 낮추기(apimanager protocol적용)
    • 2. ViewModel XCTest

Branch Test 2

Branch Test 2

  • 기존에 작성된 주석을 삭제함.

RxSwift 적용_2

  • APIManager - performRequest, fetchMovies, downloadImage
  • ViewModel - 영화목록, 정보 등 Observable 처리
  • MainViewController - View binding 처리

Feedback 사항 적용

  • 1. 이미지 캐시 적용
  • 2. 로딩 or 스켈레톤뷰 띄우기
  • 3. 상수 분리 (예. url)
  • 4. 접근 제어자

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.