Settings icon unproportionately big about file-type-icons HOT 6 CLOSED

I'll take a look. Thanks for reporting!

from file-type-icons.

I took a quick look and yes, the Settings icon reaches two pixels higher than some other icons from the same set:

(I accidentally cut one pixel off the top of the Settings icon.)

On the other hand:

• I actually don't own the Settings icon. It is placed there by the settings-view package
• I double-checked and the content box for both the Settings icon and my icons is 16x16, so any variation between the two is due to the Octicons font

I'll take another look tomorrow.

from file-type-icons.

Reckon we should file upstream? Cosmetics "bugs" are always a matter of opinion.

from file-type-icons.

You could file it upstream, but after looking at various icons from the set, variations in size are apparently by design:

• Fill the whole box
  • https://octicons.github.com/icon/tools/
  • https://octicons.github.com/icon/sign-out/
• Fill vertically but not horizontally
  • https://octicons.github.com/icon/jersey/
  • https://octicons.github.com/icon/organization/
• Have obvious padding on all sides
  • https://octicons.github.com/icon/git-merge/
  • https://octicons.github.com/icon/globe/
  • https://octicons.github.com/icon/issue-reopened/

from file-type-icons.

Thanks for the exhaustive information. Even if this ends up changing nothing, its still good for record keeping.

from file-type-icons.

Absolutely! Thanks again for reporting this. I'm always interested in seeing how other people use my packages and how they look at things differently. It helps me write the next ones better 😀

Unfortunately, there's nothing I feel like I can reasonably do about this, so I'm going to close this for now. If I think of something though, I'll reopen it.

from file-type-icons.