I tried some method for signing a transaction/message before EIP155 (chainid=0 or without chainid) but it doesn't work. The signed TX can recover but with different Address.
I'm using Ledger Nano X

It seems to be not possible to sign EIP-712-based messages right now, because the message is prepended with \x19Ethereum Signed Message:\n here:

This is already implemented by MetaMask, and it would be nice to be able to sign EIP-712 messages with Ledger devices as well.

With it being more and more common that users interact with multiple chains it is extremely important that the ledger display some unique identifier so that chains can be differentiated.

As a user I need to know whether I'm signing a transaction for mainnet, ropsten, binance smart chain or xDai. Am I sending 2 ETH (~4500$), 2 BNB (~1000$) or 2 xDAI (~2$)? While additionally displaying the symbol of the specific chain instead of 'ETH' simply showing the chain id would likely be enough. Something like "Chain ID: 0x56".

The fact that one cannot discern for which chain a transaction is being signed is a major security risk.

make -f Makefile.genericwallet BOLOS_ENV=/home/rstorm/ledger_ubuntu/ledger/bolos_env BOLOS_SDK=/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk CHAIN=ethereum

TARGET_NAME=TARGET_NANOS TARGET_ID=0x31100002
[GLYPH] Compiling...
/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/Makefile.glyphs:29: recipe for target 'src/glyphs.h' failed
make: [src/glyphs.h] Error 1 (ignored)
An error occured
An error occured
Prepare directories
[DEP]  dep/usbd_ioreq.d
[DEP]  dep/usbd_hid_impl.d
[DEP]  dep/usbd_hid.d
[DEP]  dep/usbd_ctlreq.d
[DEP]  dep/usbd_core.d
[DEP]  dep/usbd_conf.d
[DEP]  dep/usbd_ccid_if.d
[DEP]  dep/usbd_ccid_core.d
[DEP]  dep/usbd_ccid_cmd.d
[DEP]  dep/uint256.d
[DEP]  dep/u2f_transport.d
[DEP]  dep/u2f_service.d
[DEP]  dep/u2f_processing.d
[DEP]  dep/u2f_io.d
[DEP]  dep/tokens.d
[DEP]  dep/syscalls.d
[DEP]  dep/pic_internal.d
[DEP]  dep/pic.d
[DEP]  dep/os_printf.d
[DEP]  dep/os_io_seproxyhal.d
[DEP]  dep/os.d
[DEP]  dep/main.d
src_genericwallet/main.c:29:10: fatal error: 'glyphs.h' file not found
#include "glyphs.h"
         ^~~~~~~~~~
1 error generated.
[DEP]  dep/glyphs.d
[DEP]  dep/ethUtils.d
[DEP]  dep/ethUstream.d
TARGET_NAME=TARGET_NANOS TARGET_ID=0x31100002
[CC]	  obj/ethUstream.o
[CC]	  obj/ethUtils.o
[CC]	  obj/glyphs.o
[CC]	  obj/main.o
src_genericwallet/main.c:1758:6: warning: initializing 'const char *' with an expression of type 'volatile char [43]'
      discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
     fullAddress,
     ^~~~~~~~~~~
src_genericwallet/main.c:2213:18: warning: passing 'volatile char [43]' to parameter of type 'char *' discards
      qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        snprintf(fullAddress, sizeof(fullAddress), "0x%.*s", 40,
                 ^~~~~~~~~~~
/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/include/os.h:862:20: note: passing argument to parameter 'str' here
int snprintf(char *str, size_t str_size, const char *format, ...);
                   ^
src_genericwallet/main.c:2217:9: warning: incompatible pointer types assigning to 'bagl_element_callback_t' (aka
      'const struct bagl_element_e *(*)(const struct bagl_element_e *)') from 'unsigned int (const bagl_element_t *)'
      (aka 'unsigned int (const struct bagl_element_e *)') [-Wincompatible-pointer-types]
        UX_DISPLAY(ui_address_nanos, ui_address_prepro);
        ^                            ~~~~~~~~~~~~~~~~~
/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/include/os_io_seproxyhal.h:343:30: note: expanded from macro
      'UX_DISPLAY'
    ux.elements_preprocessor = preprocessor;                                   \
                             ^ ~~~~~~~~~~~~
src_genericwallet/main.c:2233:14: warning: initializing 'uint8_t *' (aka 'unsigned char *') with an expression of type
      'const uint8_t [5]' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
    uint8_t *ticker = TICKER_ETH;
             ^        ~~~~~~~~~~
src_genericwallet/main.c:2283:32: warning: incompatible integer to pointer conversion initializing
      'tokenDefinition_t *' (aka 'struct tokenDefinition_t *') with an expression of type 'unsigned int'
      [-Wint-conversion]
            tokenDefinition_t *currentToken = PIC(&TOKENS[i]);
                               ^              ~~~~~~~~~~~~~~~
src_genericwallet/main.c:2319:16: warning: passing 'volatile char [43]' to parameter of type 'char *' discards
      qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        strcpy(fullAddress, "Contract");
               ^~~~~~~~~~~
/usr/include/string.h:125:39: note: passing argument to parameter '__dest' here
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
                                      ^
src_genericwallet/main.c:2374:5: warning: incompatible pointer types assigning to 'bagl_element_callback_t' (aka
      'const struct bagl_element_e *(*)(const struct bagl_element_e *)') from 'unsigned int (const bagl_element_t *)'
      (aka 'unsigned int (const struct bagl_element_e *)') [-Wincompatible-pointer-types]
    UX_DISPLAY(ui_approval_nanos, ui_approval_prepro);
    ^                             ~~~~~~~~~~~~~~~~~~
/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/include/os_io_seproxyhal.h:343:30: note: expanded from macro
      'UX_DISPLAY'
    ux.elements_preprocessor = preprocessor;                                   \
                             ^ ~~~~~~~~~~~~
src_genericwallet/main.c:2431:40: warning: passing 'const char [27]' to parameter of type 'unsigned char *' discards
      qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        cx_hash((cx_hash_t *)&sha3, 0, SIGN_MAGIC, sizeof(SIGN_MAGIC) - 1,
                                       ^~~~~~~~~~
/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/include/cx.h:403:51: note: passing argument to parameter 'in' here
                    int mode, unsigned char WIDE *in PLENGTH(len),
                                                  ^
src_genericwallet/main.c:2444:40: warning: passing 'char [11]' to parameter of type 'unsigned char *' converts between
      pointers to integer types with different sign [-Wpointer-sign]
        cx_hash((cx_hash_t *)&sha3, 0, tmp, pos, NULL);
                                       ^~~
/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/include/cx.h:403:51: note: passing argument to parameter 'in' here
                    int mode, unsigned char WIDE *in PLENGTH(len),
                                                  ^
src_genericwallet/main.c:2465:22: warning: passing 'volatile char [43]' to parameter of type 'char *' discards
      qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        array_hexstr(fullAddress, hashMessage, HASH_LENGTH / 2);
                     ^~~~~~~~~~~
src_genericwallet/main.c:164:25: note: passing argument to parameter 'strbuf' here
void array_hexstr(char *strbuf, const void *bin, unsigned int len) {
                        ^
src_genericwallet/main.c:2469:22: warning: passing 'volatile char *' to parameter of type 'char *' discards qualifiers
      [-Wincompatible-pointer-types-discards-qualifiers]
        array_hexstr(fullAddress + HASH_LENGTH / 2 * 2 + 3,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src_genericwallet/main.c:164:25: note: passing argument to parameter 'strbuf' here
void array_hexstr(char *strbuf, const void *bin, unsigned int len) {
                        ^
src_genericwallet/main.c:2477:9: warning: incompatible pointer types assigning to 'bagl_element_callback_t' (aka
      'const struct bagl_element_e *(*)(const struct bagl_element_e *)') from 'unsigned int (const bagl_element_t *)'
      (aka 'unsigned int (const struct bagl_element_e *)') [-Wincompatible-pointer-types]
        UX_DISPLAY(ui_approval_signMessage_nanos,
        ^
/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/include/os_io_seproxyhal.h:343:30: note: expanded from macro
      'UX_DISPLAY'
    ux.elements_preprocessor = preprocessor;                                   \
                             ^ ~~~~~~~~~~~~
12 warnings generated.
[CC]	  obj/os.o
[CC]	  obj/os_io_seproxyhal.o
[CC]	  obj/os_printf.o
[CC]	  obj/pic.o
[CC]	  obj/pic_internal.o
[CC]	  obj/syscalls.o
[CC]	  obj/tokens.o
[CC]	  obj/u2f_io.o
[CC]	  obj/u2f_processing.o
src_genericwallet/u2f_processing.c:32:22: warning: unused variable 'SW_SUCCESS' [-Wunused-const-variable]
static const uint8_t SW_SUCCESS[] = {0x90, 0x00};
                     ^
src_genericwallet/u2f_processing.c:33:22: warning: unused variable 'SW_PROOF_OF_PRESENCE_REQUIRED'
      [-Wunused-const-variable]
static const uint8_t SW_PROOF_OF_PRESENCE_REQUIRED[] = {0x69, 0x85};
                     ^
src_genericwallet/u2f_processing.c:37:22: warning: unused variable 'DUMMY_ZERO' [-Wunused-const-variable]
static const uint8_t DUMMY_ZERO[] = {0x00};
                     ^
src_genericwallet/u2f_processing.c:44:22: warning: unused variable 'NOTIFY_USER_PRESENCE_NEEDED'
      [-Wunused-const-variable]
static const uint8_t NOTIFY_USER_PRESENCE_NEEDED[] = {
                     ^
src_genericwallet/u2f_processing.c:71:22: warning: unused variable 'DUMMY_USER_PRESENCE' [-Wunused-const-variable]
static const uint8_t DUMMY_USER_PRESENCE[] = {SIGN_USER_PRESENCE_MASK};
                     ^
5 warnings generated.
[CC]	  obj/u2f_service.o
In file included from src_genericwallet/u2f_service.c:26:
src_genericwallet/u2f_timer.h:27:16: warning: redefinition of typedef 'u2fTimer_t' is a C11 feature
      [-Wtypedef-redefinition]
typedef void (*u2fTimer_t)(struct u2f_service_t *service);
               ^
src_genericwallet/u2f_service.h:34:16: note: previous definition is here
typedef void (*u2fTimer_t)(struct u2f_service_t *service);
               ^
src_genericwallet/u2f_service.c:79:5: warning: implicit declaration of function 'u2f_io_send' is invalid in C99
      [-Wimplicit-function-declaration]
    u2f_io_send(buffer, len, service->packetMedia);
    ^
src_genericwallet/u2f_service.c:80:5: warning: implicit declaration of function 'u2f_io_close_session' is invalid in
      C99 [-Wimplicit-function-declaration]
    u2f_io_close_session();
    ^
src_genericwallet/u2f_service.c:117:13: warning: implicit declaration of function 'os_memset' is invalid in C99
      [-Wimplicit-function-declaration]
            os_memset(service->outputBuffer, 0, USB_SEGMENT_SIZE);
            ^
src_genericwallet/u2f_service.c:118:13: warning: implicit declaration of function 'os_memmove' is invalid in C99
      [-Wimplicit-function-declaration]
            os_memmove(service->outputBuffer + offset, service->channel, 4);
            ^
5 warnings generated.
[CC]	  obj/u2f_transport.o
src_genericwallet/u2f_transport.c:37:9: warning: implicit declaration of function 'os_memmove' is invalid in C99
      [-Wimplicit-function-declaration]
        os_memmove(channel, buffer, 4);
        ^
src_genericwallet/u2f_transport.c:41:5: warning: implicit declaration of function 'u2f_io_open_session' is invalid in
      C99 [-Wimplicit-function-declaration]
    u2f_io_open_session();
    ^
src_genericwallet/u2f_transport.c:67:18: warning: implicit declaration of function 'os_memcmp' is invalid in C99
      [-Wimplicit-function-declaration]
                (os_memcmp(channel, service->lastContinuationChannel, 4) !=
                 ^
src_genericwallet/u2f_transport.c:190:9: warning: implicit declaration of function 'u2f_io_close_session' is invalid
      in C99 [-Wimplicit-function-declaration]
        u2f_io_close_session();
        ^
src_genericwallet/u2f_transport.c:204:5: warning: implicit declaration of function 'os_memset' is invalid in C99
      [-Wimplicit-function-declaration]
    os_memset(service->outputBuffer, 0, MAX_SEGMENT_SIZE);
    ^
5 warnings generated.
[CC]	  obj/uint256.o
[CC]	  obj/usbd_ccid_cmd.o
[CC]	  obj/usbd_ccid_core.o
[CC]	  obj/usbd_ccid_if.o
[CC]	  obj/usbd_conf.o
[CC]	  obj/usbd_core.o
[CC]	  obj/usbd_ctlreq.o
[CC]	  obj/usbd_hid.o
[CC]	  obj/usbd_hid_impl.o
src_genericwallet/usbd_hid_impl.c:461:30: warning: passing 'volatile u2f_service_t *' (aka
      'volatile struct u2f_service_t *') to parameter of type 'u2f_service_t *' (aka 'struct u2f_service_t *')
      discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        u2f_transport_handle(&u2fService, buffer,
                             ^~~~~~~~~~~
src_genericwallet/u2f_transport.h:71:42: note: passing argument to parameter 'service' here
void u2f_transport_handle(u2f_service_t *service, uint8_t *buffer,
                                         ^
1 warning generated.
[CC]	  obj/usbd_ioreq.o
[LINK] bin/app.elf

then with generated app.hex file:

make -f Makefile.genericwallet BOLOS_ENV=/home/rstorm/ledger_ubuntu/ledger/bolos_env BOLOS_SDK=/home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk CHAIN=ethereum load

TARGET_NAME=TARGET_NANOS TARGET_ID=0x31100002
python -m ledgerblue.loadApp --path "44'/60'" --path "44'/61'" --appFlags 0x40 --path "44'/1'" --curve secp256k1 --targetId 0x31100002 --fileName bin/app.hex --appName Ethereum `ICONHEX=\`python /home/rstorm/ledger_ubuntu/ledger/nanos-secure-sdk/icon.py nanos_app_ethereum.gif hexbitmaponly 2>/dev/null\` ; [ ! -z "$ICONHEX" ] && echo "--icon $ICONHEX"`
Generated random root public key : 026a5a56114684bdc6ac1411d0bcba43de5865c4894c8822894c41e330854a2531bb957289421901cbbe927b5342f1dc6694da83274b4d05c5f7a0f6d44989104a
Using test master key 046a5a56114684bdc6ac2411d0bcba33de5865c4894c8822894c41e330854a2531bb957289421901cbbe927b5342f1dc6694da84274b4d05c5f7a0f6d44989104a
Using ephemeral key 0432f25de130bfd4529ae1a8ea0020dd70b1ebaba49c3653e2d01f5a781ff5c4732fcbeb211dc1f4912b6b6773f9453f4b6283283ea8db06b36c1bb3e61bc9f5b0
Broken certificate chain - loading from user key
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/lib/python2.7/dist-packages/ledgerblue/loadApp.py", line 174, in <module>
    loader.createApp(args.appFlags, appLength, args.appName, icon, path, None, None, args.appVersion)
  File "/usr/local/lib/python2.7/dist-packages/ledgerblue/hexLoader.py", line 163, in createApp
    data = self.encryptAES(data)
  File "/usr/local/lib/python2.7/dist-packages/ledgerblue/hexLoader.py", line 95, in encryptAES
    encryptedData = cipher.encrypt(paddedData)
  File "/usr/local/lib/python2.7/dist-packages/Crypto/Cipher/blockalgo.py", line 244, in encrypt
    return self._cipher.encrypt(plaintext)
TypeError: argument must be string or read-only buffer, not bytearray
Makefile.genericwallet:108: recipe for target 'load' failed
make: *** [load] Error 1

A while ago (this commit) a change was made so you can no longer access non-Ethereum derivation paths when using the ETH application. I'm assuming this was done for privacy reasons, e.g. to not allow an application to get addresses for other coins when a user connects their Ledger device.

The issue with this however is that it makes it impossible to recover coins sent to the wrong address. It happens a lot that people send, for example, ETC or EWT tokens to their ETH address, and as far as I know the only way to recover those funds is to use the recovery phrase. That defeats the security of the device, and we generally recommend moving all funds to a temporary address and resetting the Ledger device to get a new recovery phrase.

Trying to sign a transaction on the Ledger device for a ETC derivation path (m/44'/61'/...) currently results in Invalid data received (0x6a80). This problem could be fixed by having an option to allow all derivation paths (and chain IDs) to be used regardless of the app that is used. If there's better solutions for this (that don't involve using the recovery phrase) please let me know.

Ledger Live Version and Operating System

• tested on Ledger Live Ledger nano X, firmware 1.2.4-5 , ETH 1.6.1
• Platform and version: Windows 10

Expected behavior

Actual behavior

Steps to reproduce the behavior

Ledger cannot interact with the Eth2 SmartContrat (launchpad), the contract is not signed.

Contract data: Allow contract data in transactions -> Allowed
Ledger nano X,
Firmware 1.2.4-5 , 
App ETH 1.6.1

I have tried with different browsers, with Brave, Chrome + Metamask and with another usb cable.

the problem is happening to many people with the latest firmware.

MetaMask - RPC Error: Error: TransportStatusError: Ledger device: Condition of use not satisfied (denied by the user?) (0x6985) {code: -32603, message: "Error: TransportStatusError: Ledger device: Condit… use not satisfied (denied by the user?) (0x6985)", stack: "Error: Error: TransportStatusError: Ledger device:… use not satisfied (denied by the user?) (0x6985)"}

More people with the same problem:
https://www.reddit.com/r/ledgerwallet/comments/k0l294/unable_to_interact_with_eth2_staking_contract/

There is one line from Makefile
"DEFINES += HAVE_TOKENS_LIST # Do not activate external ERC-20 support yet"
Does it mean the ledger cannot add token transaction for the other Ethereum-like chains? Do you have any plan to add this feature?

I’d like to request that the BIP32 path lock for the generic Ethereum wallet app be removed or made less restrictive. In particular, we want to be able to export information for m/45' and any children m/45'/* (to arbitrary depth).

There are several reasons I am requesting this change:

1. The existing Bitcoin app does not have any similar BIP32 path restrictions and we are already reliant on this functionality. This proposed change would make the Ethereum app more consistent with the Bitcoin app.

2. We use the m/45'/* BIP32 space for multisig so that our users do not need to expose the m/44'/* space used by their single-sig wallets when working with us. This standard was proposed in BIP45, and is used by Electrum.

3. To generate addresses, we need to export xpubs at m/45'/*. Since the Ledger API only allows exporting public keys, to get the xpub at (say) m/45'/60', we need to be able to export the public key for both m/45'/60' and m/45' (just m/45'/* would be insufficient for us).

So the minimum request for our use-case is to open up m/45'/*, though for consistency with the bitcoin ledger app and other hardware wallets, removing the BIP32 path lock entirely would be ideal.

We suspect the required change may be as simple as changing the Makefile to remove the path restriction. In particular, changing

ifeq ($(CHAIN),ethereum)
#APP_LOAD_PARAMS += --path "44'"
...

to

ifeq ($(CHAIN),ethereum)
#APP_LOAD_PARAMS += --path "44'"
#APP_LOAD_PARAMS += --path "45'"
...

I ran across a very interesting issue while trying to add firefox support for ledger on MEW since now firefox natively supports U2F
it seems like Firefox sends u2f.register request to ledger instead of u2f.sign. I was able to verify this by using Fido U2F app on ledger nano s. The moment I try to send a sign request, firefox for some reason convert it to a register request and sends it out. This might be due to the fact that the browser remembers whether the device is registered before or not, and based on u2f standard flow you cannot sign without registering first. In order to solve this issue, ledger-app-eth might have to catch the register event as well

you can verify this issue by using ledgerjs lib on firefox. Or refer to our branch
MyEtherWallet/etherwallet#2135

Need your help guys.
I have been using my ledger with MEW for the past 3years but since I updated firmware my main address does not show up in MEW/Mycrypto/LL anymore.
I tried looking for the address on findeth but noting to be found, its like my adress never existed.

I checked the wallet on etherscan and my funds are still there but I have no way to access.

I also tried different derivation paths but it still doesn't show up.

Hope you guys can help me out or all my eth will be lost in nirvana......

According to SLIP44, all test networks are supposed to use a BIP44 path with the chain ID set to 1. At the moment, the Ethereum Ledger app will reject anything that isn't chain 60 or 61.

Add support for chain 1 as a valid BIP44 derivation path.

When using MEW and clicking the link/button to show the address on the device, the last nibble is not displayed.

So, for example, if my address was

0x04b3fAAA7c8127A80eB6D24672CfdAF4AeCABbF8

the device scroll-shows

0x04b3faaa7c8127a80eb6d24672cfdaf4aecabbf

Trying to sign a transaction interacting with a smart contract, I get this error:

"message": "Error: TransportError: Failed to sign with Ledger device: U2F DEVICE_INELIGIBLE",
"stack": "Error: TransportError: Failed to sign with Ledger device: U2F DEVICE_INELIGIBLE\n    
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:1227754\n    
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:1229201\n   
at n (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:205012)"

Trying to sign a transaction interacting with a smart contract, I get this error:

"message": "Error: TransportError: Failed to sign with Ledger device: U2F DEVICE_INELIGIBLE",
"stack": "Error: TransportError: Failed to sign with Ledger device: U2F DEVICE_INELIGIBLE\n    
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:1227754\n    
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:1229201\n   
at n (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:205012)"

Probably it is a good idea to make another bug report here, that is related to LedgerHQ/ledger-live-desktop#1753 (comment)

Ledger Nano S
Wallets: Ledger Live 12.7, 1.30, 1.32, MyEtherWallet, MyCrypto.AppImage
Platform and version: Windows 10 64bit and Ubuntu 18.04 64bit
ETC and ETH apps v1.1.8
Secure element 1.5.5 MCU 1.7

I'm not able to use ETC app on different platforms and wallets.
In all cases I'm not able to establish any connection with ETC app. If there is any error explanation available I can see an error code 0x6804
Like: Ledger device: UNKNOWN_ERROR (0x6804)

Started the process to sign the message "onetwothree"

Expected: SHA-256 message hash displayed as 4592092e1061c7ea85af2aed194621cc17a2762bae33a79bf8ce33fd0168b801

Actual: The message hash is unreadable

It looks like this repo is only current as of version 1.0.22, can only build against SDK 1.4, and needs updates for the latest SDK:

src_common/ethUstream.c:49:62: error: too few arguments to function call, expected 6, have 5
        cx_hash((cx_hash_t *)context->sha3, 0, &data, 1, NULL);
        ~~~~~~~                                              ^
/home/mk/git/nanos-secure-sdk/include/cx.h:329:9: note: 'cx_hash' declared here
SYSCALL int cx_hash(cx_hash_t *hash PLENGTH(scc__cx_scc_struct_size_hash__hash),
        ^
src_common/ethUstream.c:64:21: error: too few arguments to function call, expected 6, have 5
                NULL);
                    ^
/home/mk/git/nanos-secure-sdk/include/cx.h:329:9: note: 'cx_hash' declared here
SYSCALL int cx_hash(cx_hash_t *hash PLENGTH(scc__cx_scc_struct_size_hash__hash),
        ^
2 errors generated.

src_genericwallet/main.c:1884:79: error: too few arguments to function call, expected 8, have 7
                      sizeof(tmpCtx.transactionContext.hash), signature, &info);
                                                                              ^
/home/mk/git/nanos-secure-sdk/include/cx.h:2301:9: note: 'cx_ecdsa_sign' declared here
SYSCALL int cx_ecdsa_sign(const cx_ecfp_private_key_t WIDE *pvkey PLENGTH(
        ^
src_genericwallet/main.c:1972:68: error: too few arguments to function call, expected 8, have 7
        sizeof(tmpCtx.messageSigningContext.hash), signature, &info);
                                                                   ^

Signing transactions is not working for transactions with specific data length.

The transaction data is send in chunks to the nano ledger. If the last chunk
only contains EIP155 data (For example 018080 for the ethereum mainnet), the signature
is returned before this data is send to the nano ledger.

These methods, as implemented by Metamask respectively allow a Dapp to obtain a public key appropriate for encryption, and decrypt an encrypted payload using a private key derived from an Ethereum account's private key.

At least one Dapp already makes use of these methods; Tornado.cash, which uses these to encrypt a backup copy (which is stored on-chain) of private notes required to redeem deposits.

It would be great if we could use these methods with our Ledger-backed keys :)

References:
ethereum/EIPs#1098
https://docs.metamask.io/guide/rpc-api.html#other-rpc-methods

example

i use public key encrypt message with asynchronous encryption
encryption(
"public key",
"ManZer"
);
//023828382398a.......123213

how to use private key in ledger nano s decrypt 023828382398a.......123213 to get ManZer ?

can custom nano ledger for this case ?

We're trying to fix this issue with Ledger support for the OpenSea marketplace: MetaMask/metamask-extension#5523

The issue occurs when trying to sign unicode messages, and we think it might be something on ledger's side (as opposed to MetaMask). An easy way to reproduce this issue is to go to https://danfinlay.github.io/js-eth-personal-sign-examples/ and click personal_sign, with your MetaMask connected to a Ledger.

Thanks for your help!

Currently the code throws 0x6a80 in lots of different situations, making it hard to wallets / end users to understand what is the real problem.

Ideally we'd want a different code for every different error scenario :D

I'm not sure if this issue is already reported. Details here. I include exact versions tested (both firefox and brave browsers show exactly the same behavior) and a video demonstration for how to reproduce it.

Could we have the changelog of 1.6.3 ?

Seems to be a little patch regarding to #119 but it would be nice

Ledger Live Version and Operating System

Device: Ledger Nano S
Firmware: 1.4.2
Ledger Live Version: 1.20.0
Platform and version: Mac 10.14.5
Ledger Ethereum App: 1.1.8

Expected behavior

Select Ethereum wallet based on depravation path.

Actual behavior

Steps to reproduce the behavior

Try connecting ledger wallet with MyCrypto.

Notes

This was working when using 1.1.4 version of the Ethereum App.

Ledger Nano S firmware 1.5.5 wit Ethereum App 1.2.7
Google Chrome Version 74.0.3729.131 (Official Build) (64-bit)
having error like this
-32603 Error: TransportStatusError: Ledger device: Invalid data received (0x6a80)"}

Info:

• Ledger Nano X (Firmware 1.2.4-5)
• Ethereum App 1.6.2
• OS: Windows 10 (20H2)

Error:
Currently, when I try to sign a transaction through Metamask on the xDai chain RPC with my Ledger Nano X, this happens:

In the past, an error sometimes shows up saying that the Ledger can't sign it. I looked up the issue and other people talked about it on other websites, but couldn't seem to find a solution. I hope you can find a way to solve this as I would like to have the security of my Ledger while interacting with the xDai chain and I would like to move those tokens as well.
Thanks,
Nano X user

Contract data is turned off even if it was previously on, when updating the ledger nano s or ledger x . Thus, many interactions that were working for the user will no longer work, until somehow they figure out the cryptic error message and then manually allow contract data on the ledger device.

Instead, existing settings should be preserved where they are still supported in the new version.

I feel better about security if I can see a list of changes on new versions before I install them on my Ledger

Can we shoehorn a price ticker similar to blue-app-btc?

Env,
Ledger with firmware 1.4.1
OS - Mac 10.13.3
Mist Wallet - 0.9.3

Steps,

1. Start the Mist Ethereum Wallet and wait for the geth sync
2. Plug the Ledger and input the pin
3. Open the eth app from Ledger

Actual,
Fails to derive the eth path, with the error message "err="reply lacks public key entry""

Expected,
Should derive the path successfully

Notes,
If connect Ledger first and then start the wallet, everything is OK!

Currently we have the function get_chain_id() which fetches the chainId either from v or from chainID depending on the transaction type.
Ideally we'd like to move v to chainID, set chainID.length to vLength. I don't know if they share the same endianness.

This would simplify get_chain_id(), and allow us to call get_chain_id() in the plugins (this function would need to be exported in the ethereum-plugin-sdk).

1.6.5 & 1.6.6 missing from changelog

Hi, when confirming a ETC transaction, the recap showed on the Nano's screen show it like it is a ETH transaction, ("Amount ETH 0.5" instead of "Amount ETC 0.5").

I would like to kindly ask the maintainers to GPG sign the tags as well.

At the moment, only the commits are being signed.

The UI is very difficult to handle when signing messages. This is a great security risk. A normal interacting with smart contract is about 40 - 70 pages on the Ledger Blue until you reach the last page to confirm the transaction. This leads to possible uncertainty when you don't know what you confirming. Maybe extracting data that is most importing, like the different addresses you are interacting, and maybe a better way to see how much pages there a left.

Apparently the Makefile for this project is outdated in regards with the new SDK, more specifically there is a problem with generating the needed glyphs.c/glyphs.h.
The issue comes from using log commands in the SDK without referring to Makefile.definitions of log which causes GNU make to break and just output

file is up to date

with no error or anything from that regards, i played with the makefile and was able to generate the needed glyphs by using the terminal shell to execute instead of log

The recent update to the Ethereum Ledger app introduced some breaking changes for our users trying to stake in the SpankBank.

v1.0.24 still works for users staking SPANK on the SpankBank (https://bank.spankchain.com), users that are using v1.1.4 are not able to stake even with Contract Data 'On' and Display Data both 'On' or 'Off'.

Any guidance would be appreciated.
If necessary, here is our web3 repo for the SpankBank: https://github.com/SpankChain/spankbank-web3

It would be nice to have tests for the starkware plugin (at least the main selectors)

I use ethereum app in ledger device and want to sign transaction including property "type" for klaytn network.

It throw error message "EthAppPleaseEnableContractData: Please enable Contract data on the Ethereum app Settings" and it seems to be related to error code 0x6a80 (Invalid data)

Is it not possible to sign transaction including type property with ledger ethereum app?

Transaction is like this.

chainId: 8217
data: "0x1b2ba1140000000000000000000000009eaefb09fe4aabfbe6b1ca316a3c36afc83a393f000000000000000000000000000000000000000000000000000000000000000e00000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000"
from: "0x02e31a6132d338995e3236d2422318110540392c"
gasLimit: "0x8162c"
gasPrice: "0x05d21dba00"
nonce: 66
to: "0xc6a2ad8cc6e4a7e08fc37cc5954be07d499e7654"
type: "FEE_DELEGATED_SMART_CONTRACT_EXECUTION"
value: "0x9184e72a000"

Greetings.

I am working on EIP-1559 support at MetaMask and am doing discovery & identifying unknowns. When we pass a transaction to hw-app-ethereum for signing we send it a serialized transaction. We use @ethereumjs/tx to generate the serialized transaction which will take into consideration all of the rlp encoding needed for the new fields. When we get the v, r, s values back from ledger we append them to the transaction.

What work is required by Ledger to be able to support EIP-1559 and is there a tracking issue? I assume that ledger unserializes the transaction to display the data to the user on the hardware wallet. A similar question could be asked about EIP-2930 and any future transaction type added under the EIP-2718 Typed transaction envelope.

I'm trying to use the ledger in a Python project that uses the new web3.py version, which can no longer run under Python 2.

Is there any chance somebody could do a quick and dirty update to the examples getPublicKey.py, ethBase.py and signTx.py so that they work under Python 3? Or perhaps include alternative versions of these files that do work under Python 3, in case you want to still keep around versions that work on Python 2?

It would be an enormous help!

Contract data -> YES
Display data -> YES

When an Ethereum transaction's input data is not sufficiently padded it rejects the transaction.

For example, a transaction with the input data 0x123 would fail, while a transaction with the input data 0x123000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 would succeed.

In both cases, when display data -> NO
The transaction is accepted

Also related MyEtherWallet/etherwallet#2044

Ledger Live Version and Operating System
tested on Ledger Live 2.26.1
Platform and version: ** Mac 10.13.5 **
Expected behavior
When sending ETH you should be able to see the amount of ETH being sent on the Ledger Nano S device (2.0.0)

Actual behavior
When sending ETH the Amount section shows a partial address of the destination rather than the quantity of ETH, the destination address is then shown in full as expected on the following screen.

Steps to reproduce the behavior:
ETH app version 1.7.5

If you use mul256 to multiply two numbers and the result is greater than 2^128 the answer is erroneous. I believe I have traced the error to line 411 in uint256.c:

UPPER(UPPER(target2)) = UPPER(third64);

should be

LOWER(UPPER(target2)) = UPPER(third64);

Example: 307629525872148480000 x 1118770292985239888 = 6277101735386680763839673831077621941891705667786836541440 before the change.
307629525872148480000 x 1118770292985239888 = 344166774790893989252724830754570240000 after the change.

I am moving from a Trezor to Ledger. Trezor uses m/44'/60'/0'/0 but I think this ledger app uses m/44'/60'/0'

I found LedgerHQ/ledger-wallet-ethereum-chrome#7, but I think the issue is actually in this app instead of the chrome app.

Device: Ledger Nano X
Firmware: 1.3.0
Ethereum app: 1.7.8
OS: Ubuntu 18.04
MetaMask: 9.5.3

I'm experiencing a weird behavior when trying to swap a larger quantity of tokens on multiple DEXes on the Fantom blockchain.

For example, for the FTM/DAI pair on SushiSwap and SpookySwap and for the FTM/USDC pair on SpiritSwap, if I try to swap 4722 FTM, the ChainID being displayed on the Ledger device is the correct one (250). However, if I try to swap 4723 or more FTM on all of those 3 exchanges, I'm seeing a ChainID of 0 on the device and subsequently the transaction doesn't go through.

The error being shown is the same in all cases: Error: TransportStatusError: Ledger device: Condition of use not satisfied (denied by the user?) (0x6985)

A similar issue with the ChainID set to 0 was reported here for Matic/Polygon: MetaMask/metamask-extension#9510 and it seems like the 1.7.8 release has resolved it, however the Fantom issue still persists.

I have only observed the above while trying to do swaps of larger quantities of tokens using MetaMask and Ledger. If I use a MetaMask account, the private key for which is stored locally, I do not have any issue with these transactions, which leads me to believe it's a problem with the Ledger Ethereum app.

Does anyone have an insight as to what might be causing it?