ledgerhq / actions Goto Github PK

Hello,
This repository provides Slack notification actions which rely on Ilshidur/action-slack:

But https://github.com/Ilshidur/action-slack was archived on Jan 5. 2024, after a notice on Ilshidur/action-slack#255 :

Concerning what's coming next for this project, I consider stopping its maintenance, or at least deprecating it.
As Slack released it's official GitHub Action, I don't find any interest over maintaining an unofficial alternative, because I believe that the personal time I would commit to a project I don't use anymore will not be worth enough against the work of the Slack developers. I highly support open source and I believe that the official Action is the project to pursue. I don't plan to work on this project anymore.

I believe we should migrate to Slack Send GitHub Action (https://github.com/slackapi/slack-github-action).

We need to update set-output to use the new syntax before deprecation

• https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
• https://stackoverflow.com/questions/61858388/how-do-i-set-an-enviroment-variable-in-github-action-on-a-windows-server/65110357#65110357

Hello,

In

... output should be outputs. I believe this is why I got an empty SLACK_CUSTOM_PAYLOAD in a release workflow, https://github.com/LedgerHQ/dnswatcher/actions/runs/8357761357/job/22879739075

There could also be an issue with $JSON in the build step... Would it be possible to add echo "$JSON" at the end, to display this variable in the GitHub Actions logs? i.e. right after:

Hello,
When trying to use the slack/release action, it failed (https://github.com/LedgerHQ/dnswatcher/actions/runs/8003790776/job/21859952089):

Error: Unable to process file command 'output' successfully.
Error: Invalid format '  "blocks": ['

I guess there is a syntax error (missing \ ?) in

Or did I do anything wrong?

Hello,

When using LedgerHQ/actions/pdm/test, coverage comments are automatically added to the Pull Request (which is very nice).

But on Python projects using src/ directory, the links are broken. For example on https://github.com/LedgerHQ/dnswatcher/pull/50#issuecomment-1983628093 , the first link to __init__.py goes to https://github.com/LedgerHQ/dnswatcher/blob/1cf040fed6aab5326cc0796e1bce978a7741a223/dnswatcher/__init__.py instead of https://github.com/LedgerHQ/dnswatcher/blob/1cf040fed6aab5326cc0796e1bce978a7741a223/src/dnswatcher/__init__.py (there is a missing src/).

The action https://github.com/MishaKav/pytest-coverage-comment/tree/v1.1.50 provides a parameter for such a use-case, named coverage-path-prefix (it is used to generate GitHub permalink URL: https://github.com/MishaKav/pytest-coverage-comment/blob/v1.1.50/src/parse.js#L294 ).

An easy fix would be to enable users of LedgerHQ/actions/pdm/test to provide coverage-path-prefix to MishaKav/pytest-coverage-comment (in https://github.com/LedgerHQ/actions/blob/1cec2f273472416aaa83eb835ed7487772a0ac94/pdm/test/action.yml)

Nevertheless, something more elegant could exist. For example, as the pyproject.toml contains [tool.pdm.build] package-dir = "src" and [tool.coverage.run] source = ["src"], the action could (maybe?) request a setting to populate coverage-path-prefix automatically. What do you think?

Hello,
While trying to understand what pdm/meta is doing, I am struggling with something that I fail to understand. Here are three questions I have, which would help me better understand what is going on.

At the beginning of the action file, some outputs are defined:

=> Question 1. Why is the output has_coverage using outputs.tests instead of output.coverage?

Then, the action actually computes the outputs:

=> Question 2. These outputs are names has_.... Do the variables defined in output auto-magically add a has_ prefix?

Finally, the action computes some outputs in a step named refs, which are not referenced in the beginning.

=> Question 3. Should the beginning of the action also document target, branch, version and sha?

Could you please take a look?

Hello,
While trying to craft a release with action pdm/release, the increment is ignored and PDM always tries to perform a minor increment.

I guess that's because $INPUT_INCREMENT is always empty in

Example of failed build: https://github.com/LedgerHQ/dnswatcher/actions/runs/8003319535/job/21858406355 . It was launched with increment: MAJOR but the log show:

Run CMD=('pdm' 'bump' '--changelog-to-stdout')
bump: version 0.0.0 → 0.1.0
tag to create: 0.1.0
increment detected: MINOR

I guess ${{ inputs.increment }} maybe needs to be used in the env: block?