lebbe / pocota Goto Github PK

Before/when fixing the found bugs, proper testing must be facilitated. React Testing Library looks like a good fit.

Ultimately this should be of type ReactNode, and handed as an option to the table.

Seems to be an issue where useLayoutEffet(fn, []) runs several times after all, especially when toggling rotate. So we end up with the error "You can only promote one column to the front.".

Would be worth trying to define a RowContext for each and every row, and place information about promoted columns in this context. I think we can avoid using useLayoutEffect or useEffect at all. Updating the context from the cell is good enough.

Maintaining front promoted columns will be straight forward, because there can only exist one. So if there already is one in the context, just override it. Perhaps who is being promoted is dynamically altered.

A worse scenario is, perhaps, maintaining the back promoted rows, since there can be more of them.

I'm pretty sure this will fall apart when people start using colspan (and rowspan) in this table...

Some times the header might be unnecessary in rotated view. Especially when the row cells contains self-explanatory elements, like buttons or links.

Make an example where you can sort the table by clicking sorting buttons in the headers.

Right now it isn't possible to dynamically change the rotate property, the table doesn't update.