multiple navigate, form, index test sections and difficult to see to which model they pertain - have to guess/infer

This typo persists (I see an issue was raised/closed about it before).
Two specs titles refer to the new form for Songs.
Please change the second one to Edit, to avoid confusion.
Thanks in advance.

Submitted PR #11 to update wording to remove student confusion for why the test is failing.

The final test in genre_spec.rb uses the same wording as the previous test. The test for the new form and edit form have the same wording.

it 'shows a new form that submits content and redirects and prints out params'

This is a causing confusion for students as they think something is wrong with their new genre form when the issue is actually their edit genre form.

Updated the wording for the edit form test to instead read:

it 'shows an edit form that submits content and redirects and prints out params'

After checking with tech support that my routes were set up correctly, this test fails and can't be figured out. artists_controller_spec

describe "GET #update" do it "returns http success" do get :update expect(response).to have_http_status(:success) end end

songs index page is expected to contain genre and artist information. only way to satisfy this expectation is for each song in index list to display artist and genres of that song. this is more appropriate for the show page, not the index page.

This issue is similar to the existing one raised for the genre spec last year. The following capybara tests (within the Song spec) have identical descriptions, yet are testing two separate forms (new vs edit) in two separate view files:

 it 'shows a new form that submits content and redirects and prints out params' do
    visit new_song_path

    fill_in 'song[name]', with: "My song name"
    fill_in 'song[artist_id]', with: @artist.id
    fill_in 'song[genre_id]', with: @genre.id

    click_on "Create Song"

    expect(page).to have_content("My song name")
  end

  it 'shows a new form that submits content and redirects and prints out params' do
    @song = Song.create(name: "My Song", artist_id: @artist.id, genre_id: @genre.id)

    visit edit_song_path(@song)

    fill_in 'song[name]', with: "My edit"
    fill_in 'song[artist_id]', with: @artist.id
    fill_in 'song[genre_id]', with: @genre.id

    click_on "Update Song"

    expect(page).to have_content("My edit")
  end

Suggestion is to change the it block on the second test to indicate that the test is checking the Edit Song view/form.

The testing specs require the use of text fields (as far as i could tell) to associate a song with a song and artist on the song's show/edit pages. the user would have to know the ID of the genre and artist they would like to associate the song to in order for them to be able to create a song. this is not user friendly and also makes very little sense, which makes getting all the tests to pass a confusing mess.

the testing specs should allow for a dropdown or checkbox selection for artist/genre menus. this way it makes sense to both users and developers.

second song form test still says it's assessing the new but this should be edit

config/secrets.yml was added to .gitignore so students don't get it when they fork and clone this lab. Rails needs this file with its contents in order to run and app. Either remove this file from .gitignore and add instructions for students to create and populate this file.

This very well could have been on my end, but I had issues with the below code on my post show page. The test data seemed to be a post without a category, so any attempts to call post.category caused a no method on nil class error.

Again, very well could have been an issue with how I went about the lab on my end though.

Thanks!

<%# app/views/posts/show.html.erb %>

<%= @post.title %>

Category: <%= link_to @post.category, category_path(@post.category) %>

<%= @post.description %>

Readme should mention to use --no-test-framework when generating models and controllers. Otherwise model tests will be pending but controller tests will be generated that dont make sense with this app. @PeterBell

Tests are looking for an integer for artist_id and genre_id, but you are given a text box. Please make this clear that it's supposed to be a number!

spec for the songs form

shows a new form that submits content and redirects and prints out params
shows a new form that submits content and redirects and prints out params

should be

shows a new form that submits content and redirects and prints out params
shows an edit form that submits content and redirects and prints out params