learn-co-curriculum / python-p3-data-structures-lab Goto Github PK

Canvas Link

n/a

Concern

Rename repo to follow usual naming convention

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195247?module_item_id=439022

Concern

This lab was pretty straightforward. The confusion I encountered was where, in the README, it says:

You could use a loop to solve all of these, but try to expand your toolkit and use some other methods to make the job easier, like get(), append(), and sort()

but on get_spicy_food_by_cuisine, if you follow this guideline, there's no way to solve this without for loop, unless you do:

def get_spicy_food_by_cuisine(spicy_foods, cuisine):
    return [food for food in spicy_foods if food["cuisine"] == cuisine][0]

which is kinda weird, but then, in the solution here, they just use a for loop anyway.

There's also no questions that require using get(), append(), or sort(), but I also see that it probably used to be a question given this commented code. Could we update language here to avoid confusion?

Additional Context

No response

Suggested Changes

Probably just take out this line in the README? Whatever you guys think is best

Canvas Link

https://learning.flatironschool.com/courses/6049/assignments/195247?module_item_id=439022

Concern

When going through the lab, it was confusing at first as the read-me problems didn't match the order of the problem in the actual code. This led me into getting confused by writing the logic for one that was actually further down the list.

Additional Context

No response

Suggested Changes

No response

Link to Canvas

Issue Subtype

• Master branch code
• Solution branch code
• Code tests
• Layout/rendering issue
• Instructions unclear
• Other (explain below)

Describe the Issue

Source

Concern

(Optional) Proposed Solution

What OS Are You Using?

• OS X
• Windows
• WSL
• Linux
• IllumiDesk

Any Additional Context?