learn-co-curriculum / phase-1-using-array-reduce Goto Github PK

Canvas Link

https://learning.flatironschool.com/courses/6190/assignments/225662?module_item_id=526856

Concern

"(Then) we can then access the list of students in any Arts Showcase:" --> "We can then access the list of students in any Arts Showcase:"

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/4541/assignments/147065?module_item_id=310446

Concern

Hello!

Is this text referencing the Object.assign() method?

**Imagine we also have a sortingHat object that includes an assign() method. That method takes the name of a student as its argument and returns the name of the house the student should be assigned to. We could call this method directly:
sortingHat.assign(studentName);
**
I was under the impression that the syntax for using the Object.assign() method must be Object.assign(targetObject, sourceObject, sourceObject2, etc.). Can it be used in the manner mentioned in the text? Is there a different assign method that can be used in the manner demonstrated?

If this is just a fictional method used to illustrate a point (i.e. this method doesn't actually exist with JS), it might be better to give it a different name to avoid confusion.

Thanks!

Additional Context

No response

Suggested Changes

Use a different name for this method if it's not a real JS method. The fact that there is a real JS Object.assign() method whose syntax differs from the assign() method in the example is confusing.

Canvas Link

https://learning.flatironschool.com/courses/7741/assignments/278321

Concern

Program lesson describes that using an initial value parameter is best practice, but when used in the test, it fails. Seems as if test code should be updated to run when this is included as to not contradict lesson material.

Additional Context

none

Suggested Changes

none

Canvas Link

https://learning.flatironschool.com/courses/5284/assignments/172279?confetti=true&submitted=0

Concern

The "Demonstrate using reduce() with an Object as the Return Value" section for this lab should be replaced with a more concise block of code that explains itself.

I really shouldn't have to be reading 5 separate paragraphs to fathom what's really going on, as I really just want to look at code, and its associated patterns so I can learn the pattern, and then apply it to the assignment so it sticks.

This particular section rambles way too much and could be better off by just replacing most of the paragraphs present with just the block of code followed by an explanation paragraph so that the student gets the point.

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/5192/assignments/185980?module_item_id=413184

Concern

I think the const showcase should be const allShowcases! (in the visual studio complex reduce method example)

Additional Context

No response

Suggested Changes

I think the const showcase should be const allShowcases! (in the visual studio complex reduce method example)

Canvas Link

https://learning.flatironschool.com/courses/5649/assignments/207821?module_item_id=479040

Concern

There are no technical issues I am referring to. The example of artsShowcases and using reduce to assign "imaginary students" to the empty array value in the objects properties is a mind f. I had to re read that example like 8 times to comprehend where these names came from in the final results of the function method.

//=> [yishayGarbasz, wuTsang, mickaleneThomas] <-- wtf

this is complicated stuff and I will admit for myself I have to go over the new information a couple times for it to really start to sink in. I will be doing that for this lesson do-to it being complicated stuff to a newbie. However, I have to complain about the fact that this delicate information I am trying to understand is only made more blurry when a method is being used (showcaseAssign()) that is quoted as being unimportant for how it works for the sake of the example. I learn by taking the examples and breaking them apart and messing around with them in different ways. I can not do this when data (the students) is not given. Granted I could make my own date structure and assign it to, what the example used, (incomingStudents.reduce) but I do not know everything about JavaScript and as far as my knowledge goes that may or may not be a mistake assuming that I can just make up my own array of students. I don't know if this is making any sense but I just do not like curve balls being thrown my way when introducing a new concept. I suggest using a better example for introducing the reduce() method and its relationship to returning an object as the value. I will be going over this lesson again and hoping I find my foot in my mouth after submitting this. I understand that I may be missing something do to that fact that coding is very abstract so I will be trying to find if what I say is true still holds up in the future or not.
Final thoughts are 1). the example is barely relatable and awkward as a general real world example.
2). explain what showCaseAssign() is before throwing it into an example of a complicated abstract concept.

Additional Context

No response

Suggested Changes

Change the example I referred to.

Canvas Link

https://github.com/VernC/phase-1-using-array-reduce

Concern

When doing the test for the Phase 1 Using Array Reduce lab one of the possible coding solutions that should work for it doesn't. It works when it's run through a console and when I run it through Riplit.

Additional Context

I've attached an example of this code working in the console and on Riplit here.

Suggested Changes

No response

harry potter references