learn-co-curriculum / phase-1-context-lab Goto Github PK

Canvas Link

https://learning.flatironschool.com/courses/5841/assignments/213684?module_item_id=495556

Concern

Arguments section in the README only specifies the date argument. Missing the employeeRecord as the first argument.

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/5284/assignments/172059?module_item_id=376034

Concern

This section is incorrect within 'indextTest.js':

let rTimeData = [
["2019-01-11 0900", "2019-01-11 1300"], // 4 * 10 = 40
["2019-01-12 1000", "2019-01-12 1300"] // 3 * 10 = 40 ===> 70 total ||=> 770
];

Additional Context

No response

Suggested Changes

Corrected section:

let rTimeData = [
["2019-01-11 0900", "2019-01-11 1300"], // 4 * 10 = 40
["2019-01-12 1000", "2019-01-12 1300"] // 3 * 10 = 30 ===> 70 total ||=> 770
];

Canvas Link

https://learning.flatironschool.com/courses/4204/assignments/124414?module_item_id=256310

Concern

The mocha tests describe a function name as payrollExpense but the function being tested for is calculatePayroll.

describe("Given an array of multiple employees", function () {
   it("payrollExpense aggregates all the dates' wages and adds them together", function () {
      expect(calculatePayroll).to.exist
   })
})

Additional Context

No response

Suggested Changes

Update tests to describe calculatePayroll

Canvas Link

https://learning.flatironschool.com/courses/5300/assignments/179685?module_item_id=397126

Concern

The final test in the Context Lab contains a mistake. I couldn't get the correct value to return so I did the math by hand and the expected value for the test (11880) does not equal the actual sum of the relevant data (12480).

Additional Context

No response

Suggested Changes

Check the final test and either correct the values used to run the test so that they result in the current expected value or adjust the expected value to match the inputs.

Realized that this lab is depending on 'this' keyword primarily, please ignore and delete.