learn-co-curriculum / phase-0-html-album-cover-lab Goto Github PK

Canvas Link

https://learning.flatironschool.com/courses/7201/assignments/256330?module_item_id=606331

Concern

when you write the code that the npm test is looking for, the text on the album cover does not line up the right way. Formatting so that it fits makes the tests fail. anyone know if it matters if its suppose to line up perfectly or not

Additional Context

No response

Suggested Changes

No response

Not an issue but something to consider: Could there be a note within this lesson that using headers to adjust the size of text creates difficult to navigate pages for screen readers? "Headings create a document outline that helps screen readers navigate a document".

https://css-tricks.com/accessible-font-sizing-explained/

Canvas Link

https://learning.flatironschool.com/courses/6150/assignments/209287?module_item_id=482782

Concern

The lab states: The files you need are provided in the 'images' folder, but you'll have to write the correct URL paths (like http://..../image-name) in order for them to display correctly.
​
Need to clarify if the student will be using a value of an HTTPS link, or that path of the image within the lab directory. Students seem confused because the tests are looking for an HTTPS link, but the instructions seem to say to use the images from the images directory.

Additional Context

No response

Suggested Changes

Clarify if the student will be using an HTTPS link for the images and provide the links within the readme OR adjust the vocabulary and the example so the student can use the directory image path such so "./images/columbia-logo.png" instead of the example (like http://..../image-name)

Canvas Link

https://learning.flatironschool.com/courses/7125/assignments/245604?module_item_id=579192

Concern

Given in index.html:
<!-- Level 4 '| FROM DESPICABLE ME...' Header -->

Additional Context

No response

Suggested Changes

correct code:
<!-- Level 4 'FROM DESPICABLE ME 2' Header -->

The first

| From Despicable Me 2 |

Canvas Link

https://learning.flatironschool.com/courses/6796/assignments/234931?module_item_id=551224

Concern

im unable to actually run the code to view the web page, getting the error "crbug/1173575, non-JS module files deprecated." in the debug console. when trying to run the index file in chrome, mocha verified that the code is correct for the assignment so i submitted it anyway.

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/4318/assignments/120983?module_item_id=250683

Concern

It states to run rspec and bundle for testing but there is no gem file and not a ruby lab.

Additional Context

No response

Suggested Changes

No response

(back_cover.children.select {|ch| ch.name == "h3"}[0].children.first.text).to include("FROM DESPICABLE ME 2"), "An 'h3' tag should contain the text 'FROM DESPICABLE ME 2'" rather than just "FROM DESPICABLE ME"