learn-co-curriculum / phase-0-git-pushing-code Goto Github PK

Not sure if this is revision-worthy but in the section "Set the Destination of a Repo with ", I think it would be helpful for new students if you added "your-repository-name" to the end of the command <my_new_directory $ git remote add origin>, so they know they are supposed to paste their repo's SSH URL there.

It is stated in the "Conclusion" but it think it would be helpful in the previous section as well.

Thanks for reading my contribution!

explain/elaborate on use of 'master'

The 'Set the Destination of a Repo with Git Remote' section is confusing as it does not clearly specify that you need to paste the repository path following this terminal command 'my_new_directory $ git remote add origin.'

My suggestion would be to change the above terminal command to match the one shown in the conclusion: 'git remote add origin your-remote-repository-URL'

In this line:
my_new_directory $ git remote add origin

... there should be a prompt to paste the SSH address previously copied.

Canvas Link

https://learning.flatironschool.com/courses/5729/pages/pushing-code-with-git?module_item_id=395787

Concern

Note: the workflow you've been using for labs also pushes code for you! When you run learn test, the learn-co gem automatically creates an fis-wip branch, saves the changes you've made to that branch, and pushes it up to your copy of the repo on GitHub. Once you have all the tests passing, the lab is registered as complete on Canvas and you have a backup of your code saved on GitHub.

Additional Context

No response

Suggested Changes

I recommend to include this note in the beginning of the course. I manually pushed each of my labs onto GitHub without realizing it was automatic 😅