learn-co-curriculum / has_secure_password_lab Goto Github PK

License: Other

Ruby 82.61% JavaScript 1.84% CSS 1.91% HTML 13.64%

has_secure_password_lab's Introduction

has_secure_password

Objectives

We're going to make a Rails app that covers a simple authentication flow: users can create accounts, log in, and log out.

Introduction

Our app has three pages:

A signup page, where the user enters their username (as name), password, and password confirmation.
A login page, where the user submits their username (as name) and password and are then logged in.
A user homepage, which says, "Hi, #{name}."

We're not covering validations in this lab, so don't worry about those. (Password validations are hard to get right anyway; it's surprisingly easy to produce rules which decrease password security rather than enhance it.)

Users should not be able to log in if they enter an incorrect password. Just redirect them back to the login page. If you want to present an error, you can either return an HTTP error from the controller and catch it with Javascript, or set a flash.

Instructions

Create a User model and migrations.
Create a Users controller. It should respond to new with the signup form, and respond to create by creating a new user.
Create a Sessions controller and the appropriate actions.
Create a user homepage. You can either create a controller for it (a WelcomeController is a reasonable thing that you'll see frequently), or you can make it an action in the User's controller.

Happy coding.

has_secure_password_lab's People

Contributors

Watchers

Forkers

dev-learn-co-curriculum jminterwebs learn-co-students mzakzook wizardywizard assansav chalpenny bonjourannie jahman07104 stabassum rhtaylor ericiscoding hamcodes munroe1786 chrisbaptiste83 mrwinston700 chriskay25 dukhyunko93 melindadiaz07 giuliacajati sagbeyeg ajakcyer laurencun mikesap kylefarmer85 see-bet-code tjbigelow jrwatson94 noble-webb zackcarlson014 betalantz mkoenke jomariepolanco dddelavega14 nohaderf nnhk23 dyson1602 jonnyhak warrenniu patriciaarnedo jlorda aru120 mathlete01 damcodes jrshort89 gamil91 wlytle sarabastian joshua-flatiron raaynaldo lagofelipe alecgrey arielvgrubbs saief124 connormul jcastro506 k-will22 j-armah arelton thecodeplanner bmoclay ashill99 muhidin123 rakitzis45 turpp karegan4 mjones1818 spenser6131 ggebre smassarsky mimirandi21 ar00gula bellaappel madelinemc maryannn28 thequeenbeebs chinguyen21 ocawthorne danielyankiver clairedeboer kirstybrews jmarthaller jpersons24 jkang91 jasonnnz danajackson2 dwisecar crrojas88 racross1 bclarke329 jratana1 apang20 alexanderbowers andrudog7 zoekirsh lmontanari20 noelanimanini wcharlesknight brian-li96 billyott

has_secure_password_lab's Issues

Lesson calls for the implementation of "username" but tests only call for "name"

The lesson calls for the User object to have a "username" attribute, and even to interpolate as such, but the specs call only for the use of "name". Thank you

The lesson calls for the use of username, but the tests call for name only

The lesson calls for the implementation of a "username" attribute for Users, but only tests for a "name" attribute. It even suggests interpolating "Hi, #{username}" at a type of home page. This results in an error of "undefined method username for User object" because the tests are only instantiating users with the "name" attribute. This can be remedied by either changing the lesson from "username" to "name", or by changing the tests from "name" to "username". Thank you.

Local Tests not turning green or red

I finished the lab and was able to do a pull request, but learn is not responding to the local test. This makes me unable to 100% complete the lab.

No repo

There is no repo to run from learn.co. Either using learn open or the github link

This lab is still broken

users_controller_spec.rb expecting redirect_to may be bad practice

 it "redirects you if your password and confirmation don't match" do
      typo = steven.merge(password_confirmation: 'uni111verse')
      post :create, params: { user: typo }
      expect(response).to redirect_to(controller: 'users', action: 'new')
 end

We should be able to use render :new, that way the user's name is still pre-fill in the text field. However, the test is expecting us to use redirect_to

This Lab Requires bcrypt But Has It Commented Out In the Gemfile

This lab is asking the user to use has_secure_password but the gem bcrypt line is commented out in the Gemfile.

config/routes.rb file defines /users/new twice

@Lukeghenco: as mentioned, the /users/new route is defined twice in the solution branch, once as get '/users/new' (line 2) and again as resources :user (line 8). Since the lab's README specs that the UsersController should response to #new and #create actions, would it make sense to remove line 2, revise line 8 to resources :user, only: [:new, :create]?