learn-co-curriculum / flatiron-bnb-associations Goto Github PK

License: Other

Ruby 82.51% JavaScript 1.86% CSS 1.92% HTML 13.72%

flatiron-bnb-associations's Issues

Test variable new_york_city is inconsistently named later in tests

In city_spec.rb --

The tests start referring to it as nyc later without having declared it. Changing nyc to new_york_city solves the issue.

"nyc" instead of "new_york_city" in spec/models/city_spec

In line 5 of spec/models/city_spec.rb, a new City object, "new_york_city," is created.

In the following lines, the "new_york_city" variable is referenced incorrectly as "nyc," causing the tests to fail:

gemfile issue

after running the commands:
bundle install
learn

There was an issue with the gemfile specification. Short story is I fixed it by having the gemfile.lock require spring 2.0.2 instead of 1.3.3. However, I don't think this error was meant to be a part of the learning process.

I received the following error:

`WARN: Unresolved specs during Gem::Specification.reset:
      activesupport (>= 4.2)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
/home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/bundler-1.15.4/lib/bundler/runtime.rb:317:in `check_for_activated_spec!': You have already activated spring 2.0.2, but your Gemfile requires spring 1.3.3. Prepending `bundle exec` to your command may solve this. (Gem::LoadError)
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/bundler-1.15.4/lib/bundler/runtime.rb:32:in `block in setup'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/bundler-1.15.4/lib/bundler/runtime.rb:27:in `map'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/bundler-1.15.4/lib/bundler/runtime.rb:27:in `setup'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/bundler-1.15.4/lib/bundler.rb:101:in `setup'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/bundler-1.15.4/lib/bundler/setup.rb:9:in `<top (required)>'
	from /home/williamhancharek/.rvm/rubies/ruby-2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:121:in `require'
	from /home/williamhancharek/.rvm/rubies/ruby-2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:121:in `require'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/spring-2.0.2/lib/spring/commands.rb:33:in `<module:Spring>'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/spring-2.0.2/lib/spring/commands.rb:4:in `<top (required)>'
	from /home/williamhancharek/.rvm/rubies/ruby-2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:69:in `require'
	from /home/williamhancharek/.rvm/rubies/ruby-2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:69:in `require'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/spring-2.0.2/lib/spring/server.rb:9:in `<top (required)>'
	from /home/williamhancharek/.rvm/rubies/ruby-2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:128:in `require'
	from /home/williamhancharek/.rvm/rubies/ruby-2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:128:in `rescue in require'
	from /home/williamhancharek/.rvm/rubies/ruby-2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:39:in `require'
/home/williamhancharek/Documents/learn/flatiron-bnb-associations-cb-000/spec/models/city_spec.rb:3:in `<top (required)>': uninitialized constant City (NameError)
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/configuration.rb:1226:in `load'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/configuration.rb:1226:in `block in load_spec_files'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/configuration.rb:1224:in `each'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/configuration.rb:1224:in `load_spec_files'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/runner.rb:97:in `setup'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/runner.rb:85:in `run'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/runner.rb:70:in `run'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/lib/rspec/core/runner.rb:38:in `invoke'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/gems/rspec-core-3.2.1/exe/rspec:4:in `<top (required)>'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/bin/rspec:23:in `load'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/bin/rspec:23:in `<main>'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `eval'
	from /home/williamhancharek/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `<main>'

Seeding is weird

Seed task prevents tests for properties to run. Maybe set up seed task to run for specific association tests, so they only blow up when they need to. Also, to add clarity, seed task should set foreign keys using the instance variable's #id method, not but finding it in the Database. It's hard to reason about the associations otherwise.

Typo in line 1 of neighborhood_spec.rb

neighborhood_spec.rb line 1 is missing the r in require

Dependency error

// ♥ bundle exec rspec
WARN: Unresolved specs during Gem::Specification.reset:
activesupport (>= 4.2)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
/usr/local/rvm/gems/ruby-2.3.1/gems/bundler-1.13.6/lib/bundler/runtime.rb:40:in block in setup': You have already activated spring 2.0.0 , but your Gemfile requires spring 1.3.3. Prepending bundle exec` to your command may solve this. (Gem::LoadError)

Spec has an issue

https://github.com/learn-co-curriculum/flatiron-bnb-associations/blob/e5856f05d1cfa917f66660598c545a757cddfacc/spec/models/city_spec.rb#L34

On lines 20 and 34, 'nyc' had to be changed to new_york_city

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.