The README suggests that the solution should include creating additional specs for the the posts model and posts controller. I struggled with this, only to find that the solution tests are exactly as forked. I have some additional tests in my branch, I'm happy to have those included in the solution (though it doesn't appear I can make a pull request to the solution branch with only that file).

There seem to be alot of issues with tests on this lab.

As noted on another issue, need to include the sessions_helpers.rb in rails_helpers.rb file

session_helpers.rb file line 15 needs to be changed to 'Log in' rather than 'Sign in' as devise uses the term 'Log in' for the buttons.

Also sign_out_spec.rb line 16 is causing issues. I have had to comment out this line to get the test to pass.

lines 175-179
config/initializers/devise.rb

<<<<<<< HEAD
  config.reconfirmable = true
=======
  config.reconfirmable = false
>>>>>>> origin/solution

this lab, and not others around it, is causing an endless hang when bundle install is called
Resolving Dependencies...... running without end.
haven't tried to recreate on any other machine

This lab needs some major examination.

In spec/features/users/user_delete_spec, if you comment out skip 'skip a slow test', the test will run, but opens a new Firefox window and times out. Not touching that.

I truly have no idea how spec/features/visitors/about_page_spec is passing. It visits pages/about and looks for the text "About the Website", but it's nowhere in my code. It hits a No such page error when I try to visit pages/about manually.

I noticed about 90% of the submissions didn't have tests/code for Posts. I think there should be some dummy tests to help students remember to write them. Something like:

it 'writes some tests, or else it gets the hose again'
  expect(true).to eq(false)
end

would help remind students. I personally think it's just muscle memory, not laziness. "All green, next lesson."

In the instructions for this lab it says :
Once you've reached this point, all the specs should be passing. For the next part, we'll create a Post model, which has different permissions for different user roles.

I the repo that I cloned, the specs for the post controller are already created. It seems like the flow of the instructions do not match well with the flow of the tests.

The readme says: "Ensure that only administrators can update or destroy users." This is not tested in the specs.

We tell the student we've already installed devise, so they do not see the install instructions telling them to add flash messages to the application.html.erb or how to generate the devise views. We tell them how to gen the views, but don't mention anything about the flash messages.

sign_up_spec.rb:12 uses #sign_up_with method that is defined in suppord/helpers/session_helpers.rb. But, the spec can't access the method for some reason. giving this error:

Failures:

  1) Sign Up visitor cannot sign up with invalid email address
     Failure/Error: sign_up_with('bogus', 'please123', 'please123')

     NoMethodError:
       undefined method `sign_up_with' for #<RSpec::ExampleGroups::SignUp:0x007fe784ef2658>
     # ./spec/features/visitors/sign_up_spec.rb:26:in `block (2 levels) in <top (required)>'

Finished in 1.75 seconds (files took 2.23 seconds to load)
16 examples, 1 failure, 1 pending

Failed examples:

rspec ./spec/features/visitors/sign_up_spec.rb:12 # Sign Up visitor cannot sign up with invalid email address

A work around is to move the logic from that helper file to the spec. sign_up_spec.rb:12:

    visit new_user_registration_path
      fill_in 'Email', with: '[email protected]'
      fill_in 'Password', with: 'please123'
      fill_in 'Password confirmation', :with => 'please123'
      click_button 'Sign up'
    txts = [I18n.t( 'devise.registrations.signed_up'), I18n.t( 'devise.registrations.signed_up_but_unconfirmed')]
    expect(page).to have_content(/.*#{txts[0]}.*|.*#{txts[1]}.*/)

This problem occurs in the following specs (like line 25) too.
You can see my implementation here:
https://github.com/onyoo/devise_roles_lab-v-000/blob/master/spec/features/visitors/sign_up_spec.rb

The specs can't access file: spec/support/helpers/session_helpers.rb where signin is defined.

Right out of the box, if you run rspec you get:

Sign in
  user cannot sign in if not registered (FAILED - 1)

Failures:

  1) Sign in user cannot sign in if not registered
     Failure/Error: signin('[email protected]', 'please123')

     NoMethodError:
       undefined method `signin' for #<RSpec::ExampleGroups::SignIn:0x007f90393e89f8>
     # ./spec/features/users/sign_in_spec.rb:12:in `block (2 levels) in <top (required)>'

Finished in 0.0641 seconds (files took 2.19 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/features/users/sign_in_spec.rb:11 # Sign in user cannot sign in if not registered

I temporarily fixed this issue by moving the logic out of the helpers file and replacing the signin method. Starting line sign_in_spec:12:

      visit new_user_session_path
      fill_in 'Email', with: '[email protected]'
      fill_in 'Password', with: 'please123'
      click_button 'Sign in'

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

With the above code in, sign_in_spec:26:

      visit new_user_session_path
      fill_in 'Email', with: user.email
      fill_in 'Password', with: user.password
      click_button 'Log in'

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Ok ALL the tests have the same issue. Just modify them accordingly.
Can use mine as a guide:
https://github.com/onyoo/devise_roles_lab-v-000/blob/master/spec/features/users/sign_in_spec.rb

PS if you get uninitialized constant for FactoryGirl on the second test, delete your Gemfile.lock and bundle install.

Hello ,
This lab has a test bug ,
spec/users/sign_out_spec.rb line number 13 ##> signin(user.email, user.password)
there is no such a method name for Devise , the correct name is sign_in
I know that because when change the method call to ' sign_in(user.email, user.password) ' , it works and the test pass otherwise , I get the error below.

1. Sign out user signs out successfully
   Failure/Error: signin(user.email, user.password)

   NoMethodError:
   undefined method `signin' for #RSpec::ExampleGroups::SignOut:0x00000006581af0
   Did you mean? sign_in

   ./spec/features/users/sign_out_spec.rb:13:in `block (2 levels) in <top (required)>'

best ,
Ali Alrawi

The readme says, after passing all included specs, we should create a Post model with a corresponding controller and views, and write our own specs. The curriculum thus far has never expected students to write our own tests for a lab (nor taught how to do it).

in spec/features/users/sign_out_spec.rb line 13 change from

signin(user.email, user.password)
to
sign_in(user.email, user.password)

I feel like this lab has very little to do with Devise Roles overall. Lots of work in views and partials. Things like creating a nav seem out of place and just busy work. This could be by design but I feel this lab could be revised and offer more practice on roles. The video review even has Avi starting it off saying he really wants to get to the Roles part.

This set of tests checks primarily that the role set returns a certain value. If we look at this example, found on user_spec.rb:18 :

  it "#role can be set to :vip" do
    @user.role = :vip
    expect(@user.role).to eq "vip"
  end

we will get the following error:

Failures:

  1) User #role can be set to :vip
     Failure/Error: expect(@user.role).to eq :vip

       expected: :vip
            got: "vip"

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
       -:vip
       +"vip"

     # ./spec/models/user_spec.rb:20:in `block (2 levels) in <top (required)>'

To I realize the test passes with the solution, but the only way I could get it to pass was to change line 20 to:

    expect(@user.role).to eq "vip"

I'd be interested to know how else to not have it return a string.

3 test that end with lower case email don't pass unless change it to Uppercase email.
for lines 13 35 and 46