I changed test/index-test.js

In the test starting on line 72 i modified this line:

input.simulate('change', { target: { name: "name", value: 'Hello' } })

full code below:

it('updates the store when a form is submitted', () => {
const store = createStore(manageBand)

let spy = sinon.spy(store, "dispatch")

const wrapper = mount(<Provider store={store}><App /></Provider>)

expect(wrapper.find('input').length > 0, "No input elements found in the application").to.equal(true)
let input = wrapper.find('input').first()

let form = wrapper.find('form')

expect(store.getState().bands, "'bands' not found in the store").to.exist
expect(store.getState().bands, "Initial state of 'bands' should be an empty array").to.be.empty

input.simulate('change', { target: { **name: "name"**, value: 'Hello' } })

form.simulate('submit',  { preventDefault() {} })

expect(store.getState().bands[0].name).to.equal("Hello")

});

The solution does not pass test 6 "bandsComponent is a child of the app component".

Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in.
     
TypeError: Cannot read property 'contextTypes' of undefined

@Lukeghenco @aturkewi
I was having issues with npm test hanging. I didn't think much about it and finished the lab and just ctrl + c until all the test were passing. As you can see here:

In the top left tab - it is showing the running process icon which is currently hanging, however all the test passed.

When i ran 'learn' for it to update on the site i got this error.

It was stating that document was not defined.

My theory is perhaps the file structure of the lab? I noticed that in the "root" directory. Index.html is defined. But the index.js in src, would it be able to reference the dom that way? With it not being in the root of src?

Just curious. I'm going to go ahead and submit this lab. But wanted to give an update that this lab may be broken as far as running the test goes.

This lab tests for strings as opposed to objects. This is confusing, as documentation and lessons have you passing objects in state, and seems like for consistency's sake, this should happen here as well. The next lab goes right back to using objects...

As written, the BandInput tests that use const wrapper = shallow(<BandInput />) throw an "Invariant Violation: could not find 'store' in either the context or the props...." error. When corrected by passing in the store as a prop, they still don't work -- apparently because you gotta .dive() to get down past the Redux connect() wrapper and into the component (HOCs and .dive())

This works:

    const store = createStore(manageBand)
    const wrapper = shallow(<BandInput store={store} />).dive()

The second test displays the following upon failure: BandInput has an initial state with text key set to empty string, but the tests are looking for a name key, not a text key.

line 12 of index-test.js is missing an expect.

According to the test, "changes the state on a keydown" yet
<input type='text' onKeyDown={(event) => this.handleChange(event)} /> fails
and
<input type='text' onChange={(event) => this.handleChange(event)} /> passes.

According to the Readme the user should be creating the reducer. Do you want to remove some of it to allow for that?

You will also need to fill in the manageBand reducer located under ./src/reducers/manageBand.js. It will need to respond to an action of type 'ADD_BAND' and correspondingly concatenate a new band each time the action is dispatched.

Problem: This lab has tests that pass based on a specific component structure. As Redux removes the need for a particular component structure for passing props, there may be multiple 'valid' component structures for this lab, but only one structure that passes tests as they are currently written. #14

Solution: Either add tests to enforce specific component parent/child structure or modify tests to be open ended on how students can structure the given components

The tests contain objects and not an array of strings. That is trying to be submitted to the store. So some of the tests cannot be passed.

One in particular is...

Bands Container
renders each li with the correct name:
Invariant Violation: Objects are not valid as a React child (found: object with keys {name}). If you meant to render a collection of children, use an array instead.

Change: "So we will be creating two different React components each of them need to connect to our Redux store."

To: "So we will be creating two different React components**, and** each of them need to connect to our Redux store.