leapcode / leap_web Goto Github PK

• be logged in as a normal user to webapp
• log in as an admin in new tab
• switch back to non-admin
  -> email and stuff is still shown for non-admin but the view is as for admins, refreshing then shows all the data of admin

Steps to reproduce:

• view of support tickets
• click "New Ticket"
• leave the fields empty
• click "Submit Ticket"
• --> "Submit Ticket" is "Loading" and greyed out, have refresh to fill the regarding fields to submit ticket

how to reproduce on a local development install (develop branch):

• I visit the main page.
• I click on 'get help' and file a support ticket.
• on the top it says the ticket is open and has a button that allows me to close the ticket.
• clicking the button takes me to a routes error page.

It's working on https://demo.bitmask.net/ - so this most likely is a regression due to the update to rails4. My guess would be this is related to http://guides.rubyonrails.org/v4.2/upgrading_ruby_on_rails.html#http-patch

Most of the code in question lives in an engine in engines/support.

The tests are currently green - so this is obviously not covered. I think this would be a good initial issue to fix. Testing may be a bit more difficult though. Feel free to try - I'm not sure it's worth getting stuck. I'm happy to write a test case myself.

Please document issues you run into either here or update the documentation.

When the database-connection is not working and somebody is signing or logging in there is no error-message:

• an error-message should be implemented
• maybe: instead of talking to the database when signing in, it should check the database right away

I started rails server and got following error, setting up leap on my private laptop the first time - I'm not sure if it's mentioning:

Sprockets::FileNotFound at /de

couldn't find file 'srp' with type 'application/javascript'
Checked in these paths: 
  /Users/theaamanda/Programmierung/leap_web/config/customization/stylesheets
  /Users/theaamanda/Programmierung/leap_web/app/assets/images
  /Users/theaamanda/Programmierung/leap_web/app/assets/javascripts
  /Users/theaamanda/Programmierung/leap_web/app/assets/stylesheets
  /Users/theaamanda/Programmierung/leap_web/vendor/assets/javascripts
  /Users/theaamanda/Programmierung/leap_web/vendor/assets/stylesheets
  /Users/theaamanda/Programmierung/leap_web/engines/support/app/assets/javascripts
  /Users/theaamanda/.rvm/gems/ruby-2.1.5/gems/client_side_validations-simple_form-3.2.4/vendor/assets/javascripts
  /Users/theaamanda/.rvm/gems/ruby-2.1.5/gems/client_side_validations-4.2.5/vendor/assets/javascripts
  /Users/theaamanda/.rvm/gems/ruby-2.1.5/gems/jquery-rails-4.1.1/vendor/assets/javascripts
  /Users/theaamanda/.rvm/gems/ruby-2.1.5/gems/bootstrap-sass-3.3.7/assets/stylesheets
  /Users/theaamanda/.rvm/gems/ruby-2.1.5/gems/bootstrap-sass-3.3.7/assets/javascripts
  /Users/theaamanda/.rvm/gems/ruby-2.1.5/gems/bootstrap-sass-3.3.7/assets/fonts
  /Users/theaamanda/.rvm/gems/ruby-2.1.5/gems/bootstrap-sass-3.3.7/assets/images

I un-commented //= require srp in application.js and then everything worked!