league-of-foundry-developers / foundry-token-hotbar Goto Github PK

Changing the configuration makes Token Hotbar store them in a different place.
Migrating from never linked to always linked might be a problem, because then an actor can have multiple tokens with different hotbars that now need to "merge" into one.

Foundry 0.7.7
DnD5e 1.1.1
Token Hotbar 4.2.0
Link to linked actor enabled.
Always link to actor enabled.
Shared Token Hotbar enabled.

After occupying the Hotbar page with macros, if I deselect the token or selecting other tokens sometimes all the macros on that page will be cleared. It's inconsistent on how it is happening, can be happened to both GM and Player side.

When the GM changes the shared token hotbar, it does not re-render on the player's screen.

When I select a token and hotbar (page 5 in my case) pops up the rolls from it are from a different character than the selected token. Additionally, when there are multiple tokens of the same actor on board, charges and spell slots are consumed across them instead of on the ones that made the roll.

An example, let's say that I have an Acolyte on the board, with Bless and Cure Wounds on the hotbar. I cast Bless and one spell slot is consumed and an appropriate chat message appears with correct name of the token, all good for now. Add another Acolyte on the board and what happens is that the Acolyte 1 spell slots are reset (I did some testing without the module and consumed spell slots remained consumed if I followed the same scenario) and if I cast another spell with Acolyte 1 the message in chat and consumed slots are as if Acolyte 2 rolled.

I did some testing, turned off and on few modules, and it appears that Token Hotbar and Better Rolls for 5e don't like each other. Without Better Rolls for 5e it seems to be working as intended. If I were to guess I think it has something to do with how Better Rolls for 5e creates macros.

Token Hotbar version 4.2.0
Better Rolls for 5e version 1.2.1
Foundry version 0.7.8 (was happening on 0.7.7 as well)
DnD5e system version 1.1.1

Current functionality maintains the most recent token's hotbar whenever deselecting that token.

I was wondering if it was possible to have a hotbar saved in the interim, whenever no token is selected. This way, I can have separate hotbars for each token, and a main hotbar when there are no tokens in focus (such as for storytelling, or script macros).

When I click a monster that has a token hotbar set, I'd like for the token hotbar to be automatically activated. When I don't have a monster selected, I'd like the hotbar revert to automatically switch back again (revert to whatever hotbar number it was on before the token selection).

Almost always (always?), I'd like to set token hotbars for ALL unlinked tokens of the same time. For instance, I'd like to give every Skeleton a shortbow attack macro, not just the one skeleton I happened to click.

Maybe have this as a setting so that the current behavior can be preserved, if someone wants it for some reason? I'm not sure what the use case is for that though.

When player A makes an adjustment to the Token Hotbar and player B has the hotbar open, the adjustment is only observed as soon as the player redraws the custom hotbar.

This is an issue with the renderCustomHotbar hook not being called on all clients like renderHotbar is.

Check if flag['TokenHotbar']['hotbar-data'] is not set or something similar.

(Beans) To be clear you can use FTHB to set up Macros as GM that Players will inherit by being selected on their own token/character, yeah?

As a GM I would like to set macros on a tokens hotbar so that my players can use them.

As a GM I would like to lock the shared token bar, so that other players can't change it.

Dropping a spell from a Magic Item, using the Magic Items module, onto the Custom hotbar (when enabled for token hotbar) causes the spell to be placed in the same numbered slot on bar # 1 on the main macro bar instead, replacing whatever might have been there before.

As title, token hotbar seems broken on 9.2. You can drag an item/ability to the bar and it will put it on there, but as soon as you deselect the token and switch back anything you put there is gone.

When selecting a token without a token hotbar, the hotbar gets cloned.
Expected: token hotbar gets cleared.

Macros stick around when removed (right click, remove). They disappear until you deselect and reselect the token; then that macro is back. Deleting the macro actually removes it, but that's not really a workaround.

Foundry 0.8.9
Token Hotbar 4.2.2

The first few version were built in a more procedural fashion. To make development easier, it's nicer if we improve the quality of the code and use Typescript.

Also the zip seems to lack main folder, and AFAIK the folder must be all noncapitalized, but the id of the module (which afaik is same as folder) is camel-case.

The title says it all. I was under the impression that custom-hotbar was supported but not required. I do not wish to use custom-hotbar with token-hotbar but this is preventing me from enabling token-hotbar.

Perhaps I am doing something wrong?

Thank you!

Token Hotbar v3.1.0
Foundry v0.6.4

when I have the mod installed, tokens (not linked) after placing them on the map and removing or editing them the token goes back to its primary condition. (all configuration options on)

This happens on load, doesn't seem to impact the use of the module but want to make sure you're aware.

foundry.js:2499 TypeError: Cannot read property 'tokens' of null
at TokenHotbar.js:1
at Function._call (foundry.js:2496)
at Function.call (foundry.js:2481)
at CustomHotbar._render (foundry.js:4547)

It should be possible to add another hotbar on the screen.

This hotbar could then be made toggleable:

• When no token is selected, it is hidden;
• When a token is selected, it is shown.

Suggested by: @Norc

Test Info:
Foundry 0.62, D&D 0.92, Token Hotbar 1.2.3, Electron app as GM, only module installed in test world. All tokens are unlinked SRD monsters. Same behavior happened with linked tokens.

Test Steps:

1. Click a token that has a token hotbar defined with at least one macro on it
2. Deselect the token by selecting no tokens

Current behavior: Macro remains on token hotbar
Expected behavior: Token hotbar is cleared (or maybe reverts to a set of macros, like hotbars 1-4) until another token with a defined hotbar is selected.

When trying to update the module I get the attached error.

Recently updated to 0.8.X (went from 0.7.10 to 0.8.8) and getting a few errors from token hotbar. I love using this module so im hoping its not been abandoned.

Error that appears when selecting a token on the canvas

Console Log when selecting a token on the canvas

Hoping its maybe something on my end and is a simple fix. Tested with other modules disabled.

There are only a few texts that need translation in this module. It would be great if we could get them translated in as many languages at possible. If you speak a language that is not yet supported, feel free to take a look at the json files in the lang folder.

The module tries to recognize the tokens of the other levels and generate bars for them, but it cannot find an actor and it gives an error.

The token hotbar does not empty when selecting a new unlinked token, or deselecting.

This results in the module being unusable, as it creates a mishmash of all the macros you have previously selected.

Foundry 0.8.8 and Token Hotbar 4.2.2

For some reason when using both this and the "Show Drag Distance" module (which shows you how far you're dragging your token, and colors your ruler line with your player color), it turns the ruler color black, instead of keeping your player color. Not a huge deal, but I don't think it's an intended bug so I thought I'd mention it!

When updating the token hotbar on the custom hotbar, the flags are replaced with slots from 1-10 instead of 1-10 + 11-50 (if set).

Reproduction (v3+)

1. Set tokens on the core token hotbar (a page other than 1)
2. Enable Norc's Custom Hotbar in the Token Hotbar settings
3. Set some tokens
4. Disable Norc's Custom Hotbar in the Token Hotbar settings
5. Observe that the token no longer has a hotbar (flags only show macro's on slots 1-10)

I encountered this bug when setting macros on several linked tokens.
Might be related to refreshing/updates not coming through to the server? But a refresh is not always necessary to reproduce the problem.

Possibly related: save is called twice when clicking on a token with a token hotbar. Sometimes even a third time with only part of the token hotbar (less entities). It might be that save is triggered before the loading is done.

Environment:

• Foundry 0.6.2
• Token Hotbar 2.0.2
• Linux hosted, Firefox 77.0.1 client

Reproduction:

1. Add two tokens on the canvas (in my case linked to actors, but I believe it's not related)
2. Add distinct macros on each token hotbar.
3. Switch between them a few times and observe the following in the console (enable console.debug)

Notice how, after switching to Bzyx... save is called two times with the entire token hotbar flag and a third time with only a subset of it (without 6thn... macros).

When I try to assign macros to a specific token the next time I select such token the macros are missing. They can still be found in the Macros Directory. There are no error messages in the console.
I managed to use a temporary workaround with Custom Hotbar module that seems to be retaining assigned macros. If the Custom Hotbar is then disabled the macros will appear on the desired hotbar (in my case number 5).

I hit the Update All button and got a warning flag (I already had Token Hotbar installed). I tried uninstalling and reinstalling to see if that would fix the issue but unfortunately it now won't redownload and throws a similar error (see below). I tried downloading from github and installing manually, but when I do that there is no way to access the settings for some reason (probably didnt install correctly). Not sure what changed but thought I'd bring it to your attention. Thanks!