le717 / brackets-html-skeleton Goto Github PK

Don't know why I haven't done this already.

(Pulled from c65e88e)

I figured out what is going on here. When this block is run, ideally the extension logo is displayed rather than the previous (if any) image. However, what seems to be occurring (even if an unsupported image is loaded on first use) is the $imgPreview.bind("load") detection in the supported image block is detecting the load and thus treating it as a supported image.

The fix

• Find a way to isolate the load detection to not detect this change. This is pretty much all that is stopping v1.2.0 from being released

src/SvgSize.js

• Fully extract width, height, viewBox and enable-background attribute values every time they are present
• Extract values from AI, Inkscape, and minified (svgo tool) SVGs
• Handle case if one, both, or all attributes are missing

main.js

• Special routine for handing SVG graphics only
• Update input fields once the width/height is extracted
• Blank the inputs if no size is detected after one is

CSS

• Do not disproportionately display SVGs

The CSS for the image preview is conflicting with proper detection of the width/height of any image. This can be confirmed by disabling the width and height properties for .html-skeleton-image .img-preview.

While using HTML Skeleton, i found out an issue. When "Head and body w/title&meta" and "external stylesheet" are selected together, the stylesheet is rendered before . please fix this issue soon!!! :)

Replace the transform properties with position and left/right/top/bottom in css/style.css as much as possible.

If an image is selected through the file browser and it resides in the same folder as the HTML file, the root folder name will be appended instead of just the image name, creating a 404 error.

Note to myself to update the change log with the major changes made in this release.

Also, remove reference to Brackets Release 0.42 in readme. It is unneeded, as 0.44 is required.

I think this css selector in style.css is changing how Brackets' image view looks:

#img-preview

Perhaps a keyboard shortcut should be added again. The old one was removed in 17cb8af from personal perspective of being too common and better suited for Brackets core or possibly another extension. Adding a new shortcut would allow one to keep their hands on the keyboard and not have to use the mouse to click the toolbar icon or have to find it in the edit menu.

No matter what I try, it will not install. I just got the newest version of Brackets. I've tried both through the extensions manager and straight from the GIT .zip. I'm not finding any kind of error code. It simply says there was an error installing

I accidentally left some code looking for .close in main.js. It refers to the nonexistent "x" button in the dialog. Remove it and change the single reference for $openButton (no clue how I thought that's what it did) to $closeButton.

Opening as a reminder to myself.

Allow the image selection to select and insert multiple images into the document.

... to account for the local Zip file installation feature added in Release 42.

• Finish writing change log
• New screenshot
• Any other code changes needed
• Cleanly merge v1.2 branch back into master
• Tag
• Upload archive to Brackets Extension gallery

And this time, do not crop it so much!

After upgrading Brackets to sprint 36 and HTML Skeleton to 1.1.0 this morning, I was unable to get the "skeleton" html code in the editor :( I dont really know if Im doing anything wrong here. Hoping this will get fixed soon :)

Taken from adobe/brackets#6707

I was expecting a "Browse..." button where I could select the image that I wanted to insert. Would be nice if the code detected the size of the image and automatically filled in Width and Height fields. (adobe/brackets#6707 (comment))

For the image width and height, take a look in render() function in src/editor/ImageViewer.js. It looks like the "load" event for images has naturalWidth and naturalHeight properties. You could try loading image in a hidden element, but if you're going to load it, then you might as well display it in your dialog. (adobe/brackets#6707 (comment))

• Display image using Bracket's ImageViewer module - Initial work completed in v1.1.3
• Add browse button to dialog
• Invoke open dialog
• Replace logo with opened image
• Get image size and update fields with values
• Rework dialog element placement as needed