le717 / areyouona-date Goto Github PK

Endpoint: https://www.yelp.com/developers/documentation/v3/business_search
Parameters:

• latitude
• longitude
• radius: 300 meters
• categories: "restaurants"
• locale: "en_US" (sorry ☹️)
• limit: 5
• sort_by: "rating"
• price: 1,2,3,4

You may or may not be on a date. It's not totally sure.

Consider using an .env file

I like the cursive font in use for the headers, but the thin, sans-serif body font doesn't seem to match the site's theme. Find a better one.

Lowers the rating/money threshold to be considered a date

Should high accuracy geolocation data be requested or not? In current limited tests with it not being requested, accuracy variance is high, ranging from 18 meters to 900 meters (with an outlier of 5000 meters).

The Yelp API requires a radius in which to search for businesses. It needs to be set to a value that works well with the accuracy of the geolocation data. See comment

https://developer.mozilla.org/en-US/docs/Web/API/PositionOptions/enableHighAccuracy

While personally I like Taco Bell, for satire sake, add extra text in the no response if the person is at Taco Bell. This will work because it is unlikely that Taco Bell will generate a high enough score for a "yes" response (although a "maybe" response could occur in college mode).

Examples:

• "no what are you doing"
• "come for the satire, stay for the food poisoning you got from a lemonade there"

What happens if a z-score is out of range of the upper limit for a "yes" response? Do we get an error? Is it possible to for this happen at all?

The extension is broken. Use the snippet directly.

How old of geolocation results should we use? How long should we wait for a geolocation response?

Currently, they are both set to five minutes. If you have to wait 5 minutes to get a geolocation result, you're not getting a result, IMO. That one feels as if it needs to be shorter, but by how much?
https://developer.mozilla.org/en-US/docs/Web/API/PositionOptions/timeout

As far as cached geolocation data, I am unsure what to do here. People tend to move around quickly. If your location was collected 3 minutes ago but now you're at a different place, your data is out of date. Requesting a fresh result every time is not a bad idea, unless you run the assessment multiple times. Maybe a 1 minute cache would do?
https://developer.mozilla.org/en-US/docs/Web/API/PositionOptions/maximumAge

Consider using an .env file

404 and 500 responses should be good enough.