ldorau / strace.ebpf Goto Github PK

Value stored to 'stop_tracing' is never read in line 270 and 277 in src/strace.ebpf.c

Make uninstall is not implemented.

Value stored to 'res' is never read in line 114 in src/utils.c

iovisor/bcc#786

Possible division by zero in line 94 in utils/file_sc_bench.c

strace.ebpf do not compile under gcc-4.8.5

/home/mramotow/repos/pmemfile/strace.ebpf/src/libstrace/strace_bpf.c: In function ‘attach_callback_to_perf_output’:
/home/mramotow/repos/pmemfile/strace.ebpf/src/libstrace/strace_bpf.c:139:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
for (int cpu = 0; cpu < cpu_qty; cpu++) {
^
/home/mramotow/repos/pmemfile/strace.ebpf/src/libstrace/strace_bpf.c:139:2: note: use option -std=c99 or -std=gnu99 to compile your code
/home/mramotow/repos/pmemfile/strace.ebpf/src/libstrace/strace_bpf.c: In function ‘detach_all’:
/home/mramotow/repos/pmemfile/strace.ebpf/src/libstrace/strace_bpf.c:191:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
for (unsigned i = 0; i < b->pr_arr_qty; i++) {
^
src/libstrace/CMakeFiles/strace.dir/build.make:62: recipe for target 'src/libstrace/CMakeFiles/strace.dir/strace_bpf.c.o' failed
make[2]: *** [src/libstrace/CMakeFiles/strace.dir/strace_bpf.c.o] Error 1
CMakeFiles/Makefile2:547: recipe for target 'src/libstrace/CMakeFiles/strace.dir/all' failed
make[1]: *** [src/libstrace/CMakeFiles/strace.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2

Maybe use session ID?

Found on 3b3b8d9

/home/mramotow/repos/pmemfile/strace.ebpf/src/utils.c: In function ‘check_bpf_jit_status’:
/home/mramotow/repos/pmemfile/strace.ebpf/src/utils.c:241:17: warning: too many arguments for format [-Wformat-extra-args]
fprintf(file, "ERROR: cannot read status of "
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Strace.epbf gives warning when compiled with gcc 6.2.0

/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c: In function ‘test_unsupported_syscalls’:
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:126:2: warning: ignoring return value of ‘chroot’, declared with attribute warn_unused_result [-Wunused-result]
chroot(NON_EXIST_PATH_1);
^~~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c: In function ‘test_basic_syscalls’:
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:94:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
write(fd, buffer, BUF_LEN);
^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:96:2: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result]
read(fd, buffer, BUF_LEN);
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:113:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
write(0x101, buffer, 1);
^~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:114:2: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result]
read (0x102, buffer, 2);
^~~~~~~~~~~~~~~~~~~~~~~

/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c: In function ‘test_unsupported_syscalls’:
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:126:2: warning: ignoring return value of ‘chroot’, declared with attribute warn_unused_result [-Wunused-result]
chroot(NON_EXIST_PATH_1);
^~~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c: In function ‘test_basic_syscalls’:
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:94:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
write(fd, buffer, BUF_LEN);
^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:96:2: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result]
read(fd, buffer, BUF_LEN);
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:113:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
write(0x101, buffer, 1);
^~~~~~~~~~~~~~~~~~~~~~~
/home/mramotow/repos/pmemfile/strace.ebpf/test/test_syscalls.c:114:2: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result]
read (0x102, buffer, 2);
^~~~~~~~~~~~~~~~~~~~~~~

Found on revision: d80a218 with gcc 5.4 on kernel 4.8.0-34 and 4.9.4-rc4. On kernel 4.9.4 it is building.

/home/mramotow/repos/pmemfile/strace.ebpf/src/bpf_ctx.c: In function ‘attach_callback_to_perf_output’:
/home/mramotow/repos/pmemfile/strace.ebpf/src/bpf_ctx.c:141:41: warning: passing argument 3 of ‘bpf_open_perf_buffer’ makes pointer from integer without a cast [-Wint-conversion]
bpf_open_perf_buffer(callback, NULL, -1, cpu,
^
In file included from /home/mramotow/repos/pmemfile/strace.ebpf/src/bpf_ctx.c:46:0:
/usr/include/bcc/libbpf.h:72:8: note: expected ‘void *’ but argument is of type ‘int’
void * bpf_open_perf_buffer(perf_reader_raw_cb raw_cb,
^
/home/mramotow/repos/pmemfile/strace.ebpf/src/bpf_ctx.c:141:4: error: too few arguments to function ‘bpf_open_perf_buffer’
bpf_open_perf_buffer(callback, NULL, -1, cpu,
^
In file included from /home/mramotow/repos/pmemfile/strace.ebpf/src/bpf_ctx.c:46:0:
/usr/include/bcc/libbpf.h:72:8: note: declared here
void * bpf_open_perf_buffer(perf_reader_raw_cb raw_cb,
^
src/CMakeFiles/strace.ebpf.dir/build.make:146: recipe for target 'src/CMakeFiles/strace.ebpf.dir/bpf_ctx.c.o' failed
make[2]: *** [src/CMakeFiles/strace.ebpf.dir/bpf_ctx.c.o] Error 1
CMakeFiles/Makefile2:314: recipe for target 'src/CMakeFiles/strace.ebpf.dir/all' failed
make[1]: *** [src/CMakeFiles/strace.ebpf.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2

make install
[ 4%] Built target check_license_executable
[ 9%] Built target test_syscalls
[ 25%] Built target strace
[ 79%] Built target ebpf
[ 95%] Built target strace.ebpf
[100%] Built target file_sc_bench
Install the project...
-- Install configuration: ""
make uninstall
make: *** No rule to make target 'uninstall'. Stop.