Code Monkey home page Code Monkey logo

gha-mjolnir's Introduction

Mjolnir

Release Build Status Docker

Sponsor

Close issues related to the merge of a pull request.

Useful:

  • to close multiple issues related to a pull request.
  • to close issues related to a pull request not based on the default branch (ex: master, main). For example, when a branch is related to version (e.g. v1.5, v2.0, ...)

Supported Syntax

  • prefixes (case insensitive): close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved
  • issues references separators (can be mixed): (space), , (period)
  • prefix and issues references can be separated by: (space), : (colon), or both.

Examples:

Fixes #1,#2,#3
close #1, #2, #3
fix #1 #2 #3
resolve #1,#2 #3
Resolves: #1,#2,#3
closed : #1, #2, #3

Usage

name: Close issues related to a merged pull request based on master branch.

on:
  pull_request:
    types: [closed]
    branches:
      - master

jobs:
  closeIssueOnPrMergeTrigger:

    runs-on: ubuntu-latest

    steps:
      - name: Closes issues related to a merged pull request.
        uses: ldez/[email protected]
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

gha-mjolnir's People

Contributors

carolynvs avatar dependabot[bot] avatar ldez avatar martyngigg avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

gha-mjolnir's Issues

Merge Pull Request on non-default branch , but still not able auto close issue

Below is my yml file for github actions

name: Close issues related to a merged pull request from dev branches.

on:
  pull_request:
    branches:
      - dev

jobs:
  closeIssueOnPrMergeTrigger:

    runs-on: ubuntu-latest

    steps:
      - name: Closes issues related to a merged pull request.
        uses: ldez/[email protected]
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

I am already try create a pull request with commit message "Fix #30 xxx" into dev branch ( not default branch ) and approve the merge.. but it still not able to close my #30 issue after merge success.

need some help.. thanks.

Permissions needed

It seems that this need a GH token but I can't see what are the required tokens for this.

Maximum issue number is 32767

If the issue you want to close is greater than 32767, it will just attempt to close issue number 32767 (see here). This is a problem for us because our issue numbers are now >36000.

mjolnir:
2024/01/30 10:58:00 strconv.ParseInt: parsing "36727": value out of range
 version     : 
 commit      : 
 build date  : 2024-01-30_10:57:56AM
 go version  : go1.19.3
 go compiler : gc
 platform    : linux/amd64
[Fixes #36727   #36727 ]
2024/01/30 10:58:00 PR #36765: closes issue #32767, add milestones 
2024/01/30 10:58:01 PR #36765: issue #32767, add comment: Closed by #36765.

This can probably be easily fixed by changing the issue type to explicitly use int32.

Does not recognize keywords that are used multiple times

so in my PRs i tend to use text like this:

# PR details

## What changes did you make? (Give an overview)

- closes #627 
- closes #611 

...

that renders to:
image

unfortunately, your solution only picks up the first "closes" and completely skips the second. Looking at your readme, I suppose it expects closes #627, #611 instead but that does render as structured as my version which is why I would not want to shift:

image

any chance you could enhance your solution to, well, search for ALL occurrences of the keywords?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.