lchen8 / rnflicks Goto Github PK

Excellent work Lily and great use of the LinearGradient component. Only a few small critiques for your code:

• The TabApp and NavMovies components could have been decoupled more, thus cleaning up the logic within NavMovies by not using route_key to select between different URLs in NavMovies and instead just passing the url to NavMovies.
• When you have disjoint binary states sometimes it is better to combine the binary states into an Enum type to make your code easier to read, so for example !this.state.refreshing && this.state.isLoading in your app could have been this.state.loadingState === ‘loading’ and in your app the loadingState can only be one of ‘loading’, ‘refreshing’, ‘loaded’ to cover all the cases you have now. And it would also remove the special handling difference for updateRows between refreshing and loading logic.
• The copy/pasted code in MovieDetails could have been shared a bit more.
• (StarRating.js) A key with the same value as the index in an array is unnecessary, you can always get the index while you are iterating through the array, e.g., arr.map((a, key) => …)