lchen8 / flickster Goto Github PK

Hey Lily,

👍 great work. A few notes after checking out the code:

• Good to see you playing around with RelativeLayout here. Be sure to fully constrain your views in a RelativeLayout by applying rules to 2-3 edges of each view. See this guide on optimizing layouts to learn more about how to keep your screens fast.
• Good job using the ViewHolder pattern to improve performance of photos ListView. Be sure to make sure you understand view recycling and the viewholder and why are so important to creating performing lists.
• Good to see you using the YouTubePlayerView. Be sure to read more about VideoView and related libraries on that guide to make sure you understand your options for non-Youtube videos.
• Take a look at how to better organizing your source files. See if you want to try organizing packages by application feature rather than category.
• Good to see you using the resource files such as colors.xml and dimens.xml to declare those values. Be sure to avoid hardcoding any values directly into layout files whenever possible.
• Good to see you creating styles to apply to your views in styles.xml. Be sure to use styles wherever possible to keep your layout files clear of duplicate and unnecessary view presentation code.
• Always good to implement some handling of the onFailure during network calls. Ideally displaying a message on screen indicating that the load failed and to please try again. Worst case, at least display a snackbar allowing them to try again.
• Be sure to try using the ButterKnife library annotations for reducing view boilerplate substantially.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across the web and mobile platforms. This assignment also gave us our first introduction to leveraging resources, multiple configurations, optimizing lists, networking, working with APIs and loading remote images.

The next assignment will introduce new concepts such as accepting user input, working with the app bar, handling events for views and navigating between activities among other additional concepts.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply back here or email us [email protected].