lc0 / tf2up Goto Github PK

• CI/CD
• basic python lint to makefile
• run pylint test as a part of CI
• add pytest to run tests
• install package in order to simplify imports https://github.com/lc0/tf2up/pull/33/files#diff-0c81b9c94c68ea34c497c1fa52daee56R17

Count errors, have some alert to see if something goes wrong

Since now we also have a page with content would be terrific to be able to navigate to this page with a menu

AC:

• we have a menu for desktop
• we have a hamburger menu for mobile version

some links:

• https://cookies.insites.com/about-cookies/

Currently we cache such requests and serve from local cache.

if user would refresh a file, we are not going to see this.

We be more explicit on this, like adding FAQ section.
Additionally, we can add a param for URL.

details:

• jupyter/nbdime#457

Currently we just show it in plane text.
Improvement would be

• add proper error status code
• show an html page

Idea is to start tracking results of conversion, hence be able to improve problematic conversion cases for users

Not, sure how hard is it with current setup.
We can make call-to-action a bit easier by providing a URL for them

If a user has an error, once we create a content page for this migration, we can just reach out back to the user

Add an endpoint to download the converted file

some links:

• https://github.com/djdmorrison/flask-progress-example/blob/master/app.py

Idea is to create a small page for the most common errors, so users can find some suggested way to go around this issue

/notebooks/9aa78c878d63a515c666342dff10ed47/original.ipynb:115:16: ERROR: Using member tf.contrib.image.rotate in deprecated module tf.contrib. tf.contrib.image.rotate cannot be converted automatically. tf.contrib will not be distributed with TensorFlow 2.0, please consider an alternative in non-contrib TensorFlow, a community-maintained repository, or fork the required code.

some links:

• https://docs.cert-manager.io/en/latest/tutorials/acme/quick-start/index.html

so we do not have issues with concurrent conversion https://github.com/lc0/tf2up/blob/master/src/main.py#L47

Currently, since we use nbdime, we only support ipynb, but not py

Mostly about fixing CSS and make it a bit more consistent across the website

Might also include #7

Bunch of people are going to open this first on mobile.
We need to ensure, that they do not get lost

Sometimes users uses something like

%bash

echo 'something'
id

Example of notebook, that has many if such examples is https://github.com/tarrade/proj_DL_models_and_pipelines_with_GCP/blob/master/notebook/08-Mnist_keras_estimator.ipynb