lbraun / thanksgiving Goto Github PK

Not sure why I thought that was a good idea...

could work for gofundme pages, organizations, cashapp/venmo user profiles

When one user logs in they can currently see other user's donations -- should not be possible.

See http://contributor-covenant.org/ for details

Right now it's just the default:

Home#show
Find me in app/views/home/show.html.erb

GitHub is reporting vulnerabilities

create a gmail account and set it up to forward to lucas and then add the project email to the covenant file

• Add and assign them during "create recipient" flow
• color generator

We can model this off the labels in github

https://travis-ci.org/

In the index action of the donation's controller we are injecting user entered values into a sql query :/

I can fix it with this: https://stackoverflow.com/questions/40572209/rails-link-to-how-to-show-blank-when-null

It's not so obvious when it says "Please sign in." that you need to click the link in the top right corner.

It's hard to start a new donation and then have to stop and add a new recipient and then go back and start the donation again.

It links to the same thing as "Show" does. When I click on it, it just shows me that donation.

• donations view
• recipients view
• category records view
• Home
• Top bar
• Back and Edit links
• Destroy links

There are a lot of strings that are hard-coded in, for example the "Name:" text on the show pages for a donation.

Replace these with calls for translated strings :) See 84cb5b6 for how I did some of this already

Currently does not save "reasons for support"

Can't access the new donation page for some reason

Allow user to plan out what they want to give and track the status of a donation. Initially allow donation status to be "planned", "completed", or "acknowledged" for when a thank you note is received.

Acceptance criteria:

• Status can be set on creation or editing of donation
• Status is displayed on donation show page and donation index page

(unless they don't have any donations to them yet)

• Default to today's date
• Ensure acceptance of normal date formats, not just DB format

See http://edgeguides.rubyonrails.org/i18n.html as a guide.

Currently shows "Total Donations", i.e. the total amount donated to the recipient across all users. Confusing when you see a value for recipients you haven't donated to.

From @lbraun:

Yeah we should use human_attribute_name instead of humanize:
https://guides.rubyonrails.org/i18n.html#translations-for-active-record-models

Translations are stored in https://github.com/lbraun/thanksgiving/tree/main/config/locales

That's kind of a weird structure I started for them there, we could switch to having just one file for all english translations. But translations is definitely the way to handle this.

Add the following information:

• How to contribute
• How to run the app locally
• How to use the app
• How to access the deployed app?

Make it easier for the user to enter the date of the donation