layer5io / learn-layer5 Goto Github PK

Current Behavior

test_gen package doesn't currently pass the spec version it is testing. It should ideally do so.

Desired Behavior

Resources

Alternatives / Additional Context

This repo is in need of having CI.

Description

README.md is the first file one should read when starting a new project. Our community launched Discussion forum for help seekers; needs to publish it officially on README.md for convenience.

Screenshots

Current behaviour:

Desired behaviour:

Note:
Need to add only last line for Community Forum

Environment:

• OS: any [e.g. Ubuntu]
• Browser: any [e.g. Chrome, Safari]
• Version: any [e.g. 22]
• Device: any [e.g. laptop, iPhone 8]

Reference:

• Take reference to this pull request

Current Behavior

Copy/paste this workflow and this configuration into the .github folder, so that this repo will also have an automated commenter.

Desired Behavior

Resources

Alternatives / Additional Context

Contributor Resources

• 🎨 Wireframes and designs for Layer5 site in Figma (open invite)

Current Behavior

Desired Behavior

Resources

Alternatives / Additional Context

Current Behavior

The project's current issue templates are missing an open invitation link where new contributors can join the community's Figma team and view user interface designs and other UX projects.

Desired Situation

Each template that has a reference to Figma in its resources section should an invite link added.

Implementation

- 🎨 Wireframes and [designs for Layer5 site](https://www.figma.com/file/5ZwEkSJwUPitURD59YHMEN/Layer5-Designs) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/qJy1c95qirjgWQODApilR9)

Acceptance Tests
All references to Figma include the "open invite" link.

Resources

Alternatives / Additional Context

This repo is in need of having the standard issue templates.

Description
Failure of one SMI Conformance test crashes the tool and the rest of the conformance tests. The tool exits without cleaning up, but leaves resources orphaned. Instead the program should cleanup any test resources before exiting.

Expected Behavior
It makes sense that the tool might have a cascading failure for one set of tests, because one test builds on another within a set, but the tool shouldn't crash. Other test sets should continue to execute. Test resources should not be orphaned.

Environment:

• Version: meshery-osm adapter v0.1.4

Current Behavior
This line identifies the reserved port number that this adapter is be listening on - https://github.com/layer5io/learn-layer5/blob/master/smi-conformance/main.go#L16. Currently, it is using port 10008. This needs to be changed to 10011.

Implementation

• Update main.go in this repo so that the adapter listens on the specific port reserved for it, which is port 10011.
• Update Meshery Docs so that the reserved network port documentation reflects use of port 10011- https://meshery.layer5.io/docs/architecture#network-ports

Current Behavior
The CONTRIBUTING.md in this repo is missing an explanation and instructions on signing off on commits.

Desired Behavior
A copy of the same instructions from the Meshery repo's CONTRIBUTING.md's section on signing commits should be placed in into this repo's contributing instructions.

We will need to copy over the screenshots as well, which can be placed into the readme folder here - https://github.com/layer5io/learn-layer5/tree/master/img/readme

[CI] Release v0.3.0 based on significant rewrite

Description
SMI Conformance was run for one service mesh. The test failed to complete, so the meshery namespace was manually deleted. Some deploy artifacts were orphaned. When the test was invoked for a different service mesh, a collision occurred.

Logs

Error installing smi tool: rendered manifests contain a resource that already exists. Unable to continue with install: 
ClusterRoleBinding "smi-conformance" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm";
 annotation validation error: missing key "meta.helm.sh/release-name": must be set to "smi-conformance";
 annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "meshery"

Environment:

• Version: v0.5.0-beta-4

Description

Under GitHub Actions of this repository "Slack Notify on Star" job is failing for which Slack.yaml is to be Updated.

Fix

To fix this issue, update the code of Slack.yaml just by copy/pasting the code from slack.yaml of meshery

Does it make sense to instrument using https://github.com/prometheus/client_golang? // @kanishkarj

Originally posted by @leecalcote in https://github.com/layer5io/learn-layer5/pull/15/files

Description
SMI Conformance tests are timing out on some systems.

Expected Behavior
Tests should be given ample time to complete successfully.

Implementation
A quick fix is to extend the test timeout. Long-term, design of the tool needs to be a push model (event-driven), not a pull model.

Description
No template for pull requests in this repo that directs contributors on specific conventions.

Expected Behavior
A copy of this template would work well - https://github.com/layer5io/meshery/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Current State:
The SMI Conformance tests with the OSM and Kuma adapters have not been well tested using the new Conformance report.

Desired State:
Both of these adapters need to be tested and conformance results showing in the Meshery UI.

• Raise any issues found.
• Screenshot the results for docs and slides.
• Document the capability in docs.meshery.io

Contributor Resources

• Meshery documentation site
• Meshery documentation source
• Instructions for contributing to documentation

Current Behavior
Resources need to run all SMI Conformance tests in parallel can overwhelm a system.

Desired Behavior
Some systems are capable of running many test sets in parallel, while others don't have enough resources to do so.

Implementation

1. Define default number of test sets to run in parallel. Let's start with 0 meaning full parallelization.
2. Externalize the number of test sets to run in parallel. Expose this configuration in SMI Validation operation.
3. Meshery UI and mesheryctl to use it.

Description
Unaddressed issues that remain open for long periods may be automatically marked stale and closed.

Implementation
Copy stale.yml from the Meshery repo and put into the .github folder here.

Description

README.md is the first file one should read when starting a new project. For attractive look, we added some badges also.
But, there's a Slack badge, need to fix that.

Example Screenshot :-

Current Behavior

Desired Behavior

Environment:

• OS: any [e.g. Ubuntu]
• Browser: any [e.g. Chrome, Safari]
• Version: any [e.g. 22]
• Device: any [e.g. laptop, iPhone 8]

Link to issue: learn-layer5

@nveenjain are we using the "github.com/sirupsen/logrus" package here? // @anandrkskd

@nveenjain I think you were saying that use of kuttl's logger is best for the use case here, is that right?

Originally posted by @leecalcote in https://github.com/layer5io/learn-layer5/pull/15/files

Description

There's a Slack Badge failing in the README.md file.

Example Screenshots

• Current Behaviour
  

• Expected Behavior (example)
  

Environment:

• OS: any [e.g. Ubuntu]
• Browser: any [e.g. Chrome, Safari]
• Version: any [e.g. 22]
• Device: any [e.g. laptop, iPhone 8]

Desired Behavior
All Meshery adapters should support the deployment of "learn-layer5".

Description
The port has been updated from 10008 to 10011 in the smi-conformance tool, and the same needs to be updated in the deployment chart for the tool.

This new repo needs this notifier.

Current Situation
New contributors to this repo should be celebrated. A portion of this celebration can be automated.

Desired Situation
We can use a GitHub bot to do this. The config.yml, welcome folder and welcome image can be copied (and updated) from the the Meshery repo and placed into the .github folder in this repo.

Description
This gokit package is being imported from kumarabd.

Expected Behavior
The gokit package should be imported from layer5io

Implementation
After changing the location of the package import, build the project to ensure it compiles correctly (no issues with new package reference)