lauthieb / ngx-konami Goto Github PK

Hi,

I just updated my Angular 8 app to v9, and I get the following error when building.

ERROR in node_modules/ngx-konami/index.d.ts:3:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class

export declare class KonamiModule {
                       ~~~~~~~~~~~~

From what I understood it's probably linked to the use of Ivy compiler by default with Angular 9, and the fact that it is not compatible with minified and/or compiled es5 code (not sure of that part).
See: angular/angular#35255

Disabling Ivy in tsconfig does the trick so it's not such a big deal, but maybe it still could be made Ivy-compatible ?

Thanks

Hi @lauthieb

Thanks for merging PR #5

However, now that I updated to 1.7.0 I cannot import KonamiModule anymore.

import { KonamiModule } from "ngx-konami";

gives a

 error TS2307: Cannot find module 'ngx-konami'.

while

import { KonamiModule } from "ngx-konami/dist";

as mentioned in #2 gives a

ERROR in ./src/app/app.module.ngfactory.js
Module not found: Error: Can't resolve 'ngx-konami' in '/home/…/src/app'

When importing from /dist, the app is built but fails at startup with an empty page "Cannot GET /".

Any idea ? I tried completely removing the module and reinstalling it, with no success.

Thanks a lot

Hi,

With the new release v1.5.0, doing this, as specified in the README.md

import { KonamiModule } from 'ngx-konami';

no longer works and result in a error TS2307: Cannot find module 'ngx-konami';

I had to do this to work because of the dist/ folder that popped out

import { KonamiModule } from 'ngx-konami/dist';

Is it intended or did you missed something in your publish process ?

When using this with Angular 6, yarn complains about depencency versions:

warning " > [email protected]" has incorrect peer dependency "@angular/core@^4.0.0".
warning " > [email protected]" has incorrect peer dependency "rxjs@^5.1.0".

Not sure if there are code implications, but changing the dependencies to something more like "@angular/core": "4.0.0. | 5.0.0 | 6.0.0" should make yarn happy, may also want to consider moving requirements such as angular to peerDepencendies instead of being in devDependencies.

Hi @lauthieb,

When I imported the library in the app.module.ts, I got this error

ERROR in C:/Users/x_jem/Documents/Projects/www/titanxELearning/node_modules/ngx-konami/index.d.ts (4,23): Type 'ModuleWithProviders' is not generic.

ERROR in Error: Metadata version mismatch for module C:/Users/x_jem/Documents/Projects/www/titanxELearning/node_modules/ngx-konami/ngx-konami.d.ts, found version 4, expected 3, resolving symbol AppModule in C:/Users/x_jem/Documents/Projects/www/titanxELearning/src/app/app.module.ts, resolving symbol AppModule in C:/Users/x_jem/Documents/Projects/www/titanxELearning/src/app/app.module.ts

Do you have an idea what can I do to solve this?