lautaro-garcia / counsel-spotify Goto Github PK

Dear,

Thanks for this great plugin, the control play, pause, next etc working like a charming,

But when tried to search in Emacs, by invoke cunsel-spotify-search-track etc,

It always shows

helm-M-x: make client process failed: Connection refused, :name, accounts.spotify.com, :buffer, #, :host, 127.0.0.1, :service, 6152, :nowait, nil, :tls-parameters, nil

I can confirm that the client security and client Id setting is correct.

Could you please help to investigate what's wrong on my side?

Related setting is quite simple as below

;;spotify configs
(require 'counsel-spotify)
(setq counsel-spotify-client-id "fae6e6ef787743fea5b649117d9a9b2a")
(setq counsel-spotify-client-secret "7a6b41fdd292498c9ca65a3484f12090")
(global-set-key (kbd "C-c s f") 'counsel-spotify-next)
(global-set-key (kbd "C-c s b") 'counsel-spotify-previous)
(global-set-key (kbd "C-c s p") 'counsel-spotify-toggle-play-pause) 

Thanks for the help :)

After search and press RET, it show "Shell command succeded with not output" and no song played

I've noticed that the ivy-interface for searching is very slow and hangs quite a bit when entering input. It feels like a synchronous call to spotify on each character. There also seems to be a bit of a race condition when you enter a string too fast either:

1. Characters are missing
2. The window crashes

I can provide a screen recording on request.

I'm happy to look into fixing this, but wanted to validate whether this is confirmed behaviour first

Hi there. Found your package and it's cool!
Looking into the code I've noticed that you make dbus calls with shell-command dbus-send. I'm wondering what is the rationale behind that, considering that emacs has dbus support built-in.

Before installing your package I was using https://github.com/remvee/spotify-el, which implements dbus calls with dbus-call-method. It works fine.

Hi, I'm pretty confident that this is an issue with my machine, but I'd really appreciate your help in troubleshooting!

All of the counsel-spotify-search- commands give me the error ivy--dynamic-collection-cands: Wrong type argument: sequencep, 0. I've set up an application through the Spotify Developers site to get a client id and secret, and I've set those to counsel-spotify-client-id and counsel-spotify-client-secret. I'm not sure where I'm going wrong here...

I've also tried spotify.el and I haven't been able to get that working either, so it likely isn't an issue with your package. I've tried two different spotify accounts, so it's unlikely to be an account-specific issue.

Any ideas what might be going wrong? Thank you!

I get this error:

41:44: execution error: The variable nil is not defined. (-2753)

I had an issue while testing this package on Debian. The API calls would work fine, but when sending the commands through dbus, I would get the message:

dbus[4105]: arguments to dbus_message_new_method_call() were incorrect, assertion "_dbus_check_is_valid_member (method)" failed in file ../../../dbus/dbus-message.c line 1369.
This is normally a bug in some application using the D-Bus library.

  D-Bus not built with -rdynamic so unable to print a backtrace

I found that the function counsel-spotify-format-play-linux used format to supply the uri. Unfortunately, the escaping of " wasn't working on my computer ((format "OpenUri \"string:%s\"" "test") would return OpenUri \"string:test\" instead of OpenUri "string:test")

Testing with the change

(defun counsel-spotify-format-play-linux (uri)
  "Tell Spotify app to play the given URI."
  (format "OpenUri 'string:%s'" uri))

appears to work fine.

This is a duplicate of #5 but I don't have permission to reopen it.
I have spotify open, but when I do counsel-spotify-play it returns "(Shell command succeeded with no output)".
I'm on emacs 26.3, macOS 10.15.4, and counsel-spotify from melpa.

All search commands (counsel-spotify-search-album, -track, -artist etc) are failing for me:

Contacting host: accounts.spotify.com:443
cl-no-applicable-method: No applicable method: counsel-spotify-do-play, #s(counsel-spotify-linux-backend #s(counsel-spotify-backend-commands "Play" "PlayPause" "Next" "Previous")), nil

The next/previous/play commands work fine.

My API client and secret are valid since I use them with another spotify client without issue. This is Emacs 27.0.90. I am trying with the official Linux spotify client open, although I would eventually like to use spotifyd.

This is my use-package declaration:

(use-package counsel-spotify
  :ensure
  :commands counsel-spotify-start-search
  :after counsel
  :general
  (:keymaps 'space-menu-map
    "U" '(counsel-spotify-start-search :wk "spotify"))
  :config
  (defun counsel-spotify-start-search ()
    (interactive)
    (counsel-M-x "counsel-spotify-search-"))
  (setq counsel-spotify-service-name "spotify")
  (setq counsel-spotify-client-id my-counsel-spotify-client-id
        counsel-spotify-client-secret my-counsel-spotify-client-secret
        counsel-spotify-use-notifications nil))

The my-counsel-spotify- variables are set elsewhere.