laurakelly / codepath-nytsearch Goto Github PK

Hey Laura,

👍 Nice work. Here are some notes after checking out the code:

• Be sure to use styles.xml whenever possible to keep your layout files clear of duplicate and unnecessary view presentation code.
• Good use of a Toolbar within your activities. Be sure to check out how to collapse the Toolbar on scroll using the CoordinatorLayout.
• You might want to improve the look and feel of the article item results. You should play with the padding, spacing, font sizes and look into the CardView.
• Consider adding progress bars to your app whenever a network request goes out.
• Consider cleaning up your search activity to re-use a single method for both initial load and pagination
• Glad to see you used a date-time picker. To make sure the picker looks better on older devices (pre-Lollipop), you can check out third-party libraries for improved backwards compatibility.
• Be sure to try out the RecyclerView, the successor to the ListView and GridView.
• Be sure to try using the ButterKnife library annotations for reducing view boilerplate substantially.
• In the future, you might want to take a closer look at Retrofit for networking as this library is quite popular and used in many apps.
• Good to see you got sharing working using the ShareActionProvider system. Keep in mind that this is simply leveraging the implicit intent system behind the scenes. Refer to this guide on implicit intents to see other common usages of them.

Let me know if you have any other thoughts or questions about this assignment. Looking forward to seeing your Twitter submission!