latos / heroin-js Goto Github PK

So in newer Coffeescript versions (at 1.9.2 and up) the constructor, member-variable shortcut syntax like:

class SomeClass
  constructor: (@theVar) ->
   # do some stuff

Gets converted in the JS to:

SomeClass = (function() {
  function SomeClass(_at_theVar) {
    this.theVar = _at_theVar;
  }

  return SomeClass;

So heroin complains about can't find _at_theVar.

Probably outside of Heroin's responsibilities to deal with something like that, but might be worth noting for Coffeescript peeps, that you need to do the more plodding inject then assign as member vars

class SomeClass
  constructor: (theVar) ->
     @theVar = theVar

Previous versions of heroin allowed something like:

make SomeClassCtor,
        thing: "stuff"
        anotherArg: obj.notAProperty

i.e. where obj.notAProperty is null

With latest version of heroin, we have to provide explicit non-null defaults during instantiation:

make SomeCtrl,
        thing: "stuff"
        anotherArg: obj.notAProperty or ""

Often I do want an arg to have a possible null value.

Possible to allow explicitly set null values as args?

On line 59 of Heroin.js ---
return me.invoke(func, extraArgs);

Should be something like return me.invoke(func, null, extraArgs);

i.e. the extraArgs get taken as the "self" context argument on line 112.